Re: [PR] CASSANDRA-19433 Nodetool cleanup can drop data Accord might need [cassandra-accord]

["alanwang67 (via GitHub)" <gi...@apache.org>]

alanwang67 commented on code in PR #270:
URL: https://github.com/apache/cassandra-accord/pull/270#discussion_r3336752098


##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -1219,7 +1219,7 @@ private static <T extends Timestamp> ImmutableSortedMap<T, Ranges> purgeAndInser
         return ImmutableSortedMap.copyOf(build);
     }
 
-    private static ImmutableSortedMap<Timestamp, Ranges> purgeHistory(NavigableMap<Timestamp, Ranges> in, Ranges remove)
+    protected static ImmutableSortedMap<Timestamp, Ranges> purgeHistory(NavigableMap<Timestamp, Ranges> in, Ranges remove)

Review Comment:
   I think setting it to package private means that we can't access it from `CommandStores`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org