You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/02/23 03:55:23 UTC

[GitHub] [spark] hvanhovell commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass

hvanhovell commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115214435


##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
       <version>${mima.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>

Review Comment:
   I have trouble understanding how adding this to the client influences the server to do the right thing? Could you help me understand?
   
   cc @zhenlineo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org