You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "zhangxinyao88 (via GitHub)" <gi...@apache.org> on 2026/10/10 16:30:20 UTC

[PR] GH-3289: Test CLI help, version and error handling [parquet-java]

zhangxinyao88 opened a new pull request, #3848:
URL: https://github.com/apache/parquet-java/pull/3848

   ### Rationale for this change
   
   Continue #3289 with CLI behavior coverage, using the test helper added in #3843.
   
   ### What changes are included in this PR?
   
   Add 19 test cases for help and version commands, invalid commands/options, missing option values, missing required arguments, and nonexistent input files. Tests check output and exit codes.
   
   ### Are these changes tested?
   
   CLI module tests: 89 passed, 2 skipped. Spotless and license checks passed.
   
   ### Are there any user-facing changes?
   
   No. Tests only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3289: Test CLI help, version and error handling [parquet-java]

Posted by "divjotarora (via GitHub)" <gi...@apache.org>.
divjotarora commented on PR #3848:
URL: https://github.com/apache/parquet-java/pull/3848#issuecomment-6124656561

   The changes themselves LGTM but I agree with @wgtmac's question on whether such tests are necessary. Can we write a more concise set of 1-2 tests to validate basic functionality instead? Also, is the exact wording from CLI output considered a stable API? If not, these tests are brittle and I'm not sure what exact contract they're testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3289: Add basic CLI smoke tests [parquet-java]

Posted by "zhangxinyao88 (via GitHub)" <gi...@apache.org>.
zhangxinyao88 commented on PR #3848:
URL: https://github.com/apache/parquet-java/pull/3848#issuecomment-6134979807

   > Can we write a more concise set of 1-2 tests to validate basic functionality instead?
   
   Reduced to two smoke tests in 59c5aab6: version output and unknown-command failure, without asserting help or error wording.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3289: Add basic CLI smoke tests [parquet-java]

Posted by "zhangxinyao88 (via GitHub)" <gi...@apache.org>.
zhangxinyao88 commented on PR #3848:
URL: https://github.com/apache/parquet-java/pull/3848#issuecomment-6135997492

   > Reduced to two smoke tests in 59c5aab6: version output and unknown-command failure, without asserting help or error wording.
   
   Thinking about it more, these two tests may not justify a separate PR. I'd lean toward closing this and focusing on command options reaching the actual logic, as outlined in the [tracker](https://github.com/apache/parquet-java/issues/3289#issuecomment-6031117043). Let me know your thoughts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3289: Test CLI help, version and error handling [parquet-java]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #3848:
URL: https://github.com/apache/parquet-java/pull/3848#issuecomment-6105805211

   I'm just wondering do we really need test cases like this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3289: Add basic CLI smoke tests [parquet-java]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #3848:
URL: https://github.com/apache/parquet-java/pull/3848


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] GH-3289: Add basic CLI smoke tests [parquet-java]

Posted by "divjotarora (via GitHub)" <gi...@apache.org>.
divjotarora commented on PR #3848:
URL: https://github.com/apache/parquet-java/pull/3848#issuecomment-6141038170

   > > Reduced to two smoke tests in [59c5aab](https://github.com/apache/parquet-java/commit/59c5aab6c7e624eff3c165f23ed60997564bb94a): version output and unknown-command failure, without asserting help or error wording.
   > 
   > Thinking about it more, these two tests may not justify a separate PR. I'd lean toward closing this and focusing on command options reaching the actual logic, as outlined in the [tracker](https://github.com/apache/parquet-java/issues/3289#issuecomment-6031117043). Let me know your thoughts.
   
   I'll defer to @wgtmac here. IMO this doesn't need a separate PR. If we're just adding tests, my preference is a smaller set of bigger PRs rather than a large set of tiny ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org