You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 09:10:18 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #15734: chore: Add tags to gallery(iteration 1)
zhaoyongjie opened a new pull request #15734:
URL: https://github.com/apache/superset/pull/15734
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
1. Added tags of the chart to the Viz Gallery
2. The default tag value populate to `Popular` in the viz gallery
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### After
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on a change in pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on a change in pull request #15734:
URL: https://github.com/apache/superset/pull/15734#discussion_r671271150
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -206,6 +209,7 @@ const DetailsPopulated = (theme: SupersetTheme) => css`
grid-template-rows: auto 1fr;
Review comment:
grid-template-rows: auto auto 1fr;
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -220,6 +224,11 @@ const DetailsEmpty = (theme: SupersetTheme) => css`
// overflow hidden on the details pane and overflow auto on the description
// (plus grid layout) enables the description to scroll while the header stays in place.
+const TagsWrapper = styled.div`
+ grid-area: viz-tags;
+ width: ${({ theme }) => theme.gridUnit * 120}px;
+ padding-right: ${({ theme }) => theme.gridUnit * 14}px;
+`;
Review comment:
padding-bottom: ${({ theme }) => theme.gridUnit * 2}px;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kicaak commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
kicaak commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-883350962
Thanks! 💓 [Here](https://www.figma.com/file/LMnulBPitqSh5GeElVbsUV/chart-popover?node-id=0%3A1) you can find figma file with the design. You can find general requirements and some things to consider here, check out the comments I added too (the design is not perfect as I wasn't sure about the spacings, design rules etc., it's more of an initial guide that you can build on).
cc: @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45cf61f) into [master](https://codecov.io/gh/apache/superset/commit/000a038af193f2770dfe23a053bd1ff5e9e72bd4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (000a038) will **increase** coverage by `17.99%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 45cf61f differs from pull request most recent head c89eeb5. Consider uploading reports for the commit c89eeb5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
===========================================
+ Coverage 58.93% 76.92% +17.99%
===========================================
Files 373 983 +610
Lines 12014 51626 +39612
Branches 2945 6990 +4045
===========================================
+ Hits 7080 39715 +32635
- Misses 4755 11687 +6932
- Partials 179 224 +45
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.38% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.15% <0.00%> (-44.33%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `57.14% <0.00%> (-35.17%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `66.66% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `57.14% <0.00%> (-20.64%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `28.57% <0.00%> (-11.58%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `68.68% <0.00%> (-10.98%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `85.12% <0.00%> (-9.33%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `82.82% <0.00%> (-8.96%)` | :arrow_down: |
| [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | `62.50% <0.00%> (-8.56%)` | :arrow_down: |
| ... and [1129 more](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [069d5cb...c89eeb5](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c62636f) into [master](https://codecov.io/gh/apache/superset/commit/0721f54580426c4f53902c59067438adf30d5955?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0721f54) will **increase** coverage by `0.00%`.
> The diff coverage is `69.23%`.
> :exclamation: Current head c62636f differs from pull request most recent head 8e75766. Consider uploading reports for the commit 8e75766 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 983 983
Lines 51602 51613 +11
Branches 6980 6982 +2
=======================================
+ Hits 39688 39699 +11
+ Misses 11691 11690 -1
- Partials 223 224 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.35% <69.23%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.03% <69.23%> (+0.46%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0721f54...8e75766](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881706656
> it is a fullwidth search bar at the top, which makes much more sense visually.
depends on the entry point, please see video.
https://user-images.githubusercontent.com/67837651/126006312-841b2982-5a4e-4705-81db-c0a886bf727f.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-883347487
This design is awesome! thanks, @kicaak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882727364
@ktmud @suddjian @rusackas all UI/UX comments are accepted, thank you for your suggestion!
Based on your input, below mockup will be implemented in next iteration.
1. To relocate the search bar to main section
2. Search to take up the entire row
3. Stack tags above category list, only display 3-4 tags in the list
4. Click to expand and show all tags as an option
Many thanks to a freelance product designer for contributing this design❣️
cc @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-883267264
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882287403
> > An unrelated design question, does anyone else find the position of the search input weird? It looks like a search for the viz category list, not the viz types.
>
>
>
> Not to me, really... it's easy to point at other successful UIs that do this, e.g. the Mac App Store:
>
> 
>
>
>
> or other apps (Spotify, Notion, in this case) that at least put the affordance in that area.
>
> 
>
>
Except these examples do not evoke reminiscence of a regular autocomplete combobox. It's not just about the layout, but also the visual feels.
Maybe it'd solve my OCD if there are less categories and they all have icons (so they look more like tabs instead of menu items under a searchbox).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #15734:
URL: https://github.com/apache/superset/pull/15734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881473784
I also think `popular` only needs to be set to default if you are creating a chart instead of opening a chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881388666
@geido Ephemeral environment spinning up at http://54.148.202.46:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xiezhongfu edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
xiezhongfu edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881856309
* Perhaps it's worth making `viztype-selector list` have the ability to scroll.
* When Search-Input value is `Popular`, hope the `Popular` tag in the tags list is selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881716752
@suddjian Ephemeral environment spinning up at http://34.219.59.124:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881716456
@ktmud I somewhat agree on the search bar, I'll take a look at tweaking that in a separate branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xiezhongfu edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
xiezhongfu edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881856309
* Perhaps it's worth making `viztype-selector list` have the ability to scroll.
* When Search-Input value is `Popular`, hope the `Popular` tag in the RightPane is selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xiezhongfu commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
xiezhongfu commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881856309
Perhaps it's worth making `viztype-selector list` have the ability to scroll.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-883341385
> Many thanks to a freelance product designer for contributing this design❣️
Special thanks and credit goes to @kicaak 🎉 ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881723486
@junlincc I think if we have too many clickable top-level tags there will be confusion between tags and categories. It seems they are kind of becoming the same thing. We should discuss what the actual user stories are here to make sure we arrive at a design that addresses them effectively. Perhaps it would be better to do away with "categories", and just have tags instead.
Separate note: It might help to make the tags for individual charts clickable as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7afd96) into [master](https://codecov.io/gh/apache/superset/commit/0721f54580426c4f53902c59067438adf30d5955?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0721f54) will **increase** coverage by `0.01%`.
> The diff coverage is `67.39%`.
> :exclamation: Current head a7afd96 differs from pull request most recent head c839b3d. Consider uploading reports for the commit c839b3d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
==========================================
+ Coverage 76.91% 76.92% +0.01%
==========================================
Files 983 983
Lines 51602 51625 +23
Branches 6980 6990 +10
==========================================
+ Hits 39688 39714 +26
+ Misses 11691 11687 -4
- Partials 223 224 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.38% <67.39%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...onalFormattingControl/FormattingPopoverContent.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=) | `33.33% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `64.44% <59.09%> (+4.44%)` | :arrow_up: |
| [...ols/DndColumnSelectControl/utils/optionSelector.ts](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3V0aWxzL29wdGlvblNlbGVjdG9yLnRz) | `46.15% <66.66%> (+11.67%)` | :arrow_up: |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.23% <77.77%> (+0.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0721f54...c839b3d](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882727364
@ktmud @suddjian @rusackas all UI/UX comments are accepted, thank you for your suggestion!
Based on your input, below mockup will be implemented in next iteration.
1. To relocate the search bar to main section
2. Search to take up the entire row
3. Stack tags above category list, only display 3-4 tags in the list
4. Click to expand and show all tags as an option
Many thanks to a freelance product designer for contributing this design❣️
cc @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #15734:
URL: https://github.com/apache/superset/pull/15734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882727364
@ktmud @suddjian @rusackas all UI/UX comments are accepted, thank you for your suggestion!
Based on your input, below mockup will be implemented in next iteration.
1. To relocate the search bar to main section
2. Search to take up the entire row
3. Stack tags above category list, only display 3-4 tags in the list
4. Click to expand and show all tags as an option
Many thanks to a freelance product designer for contributing this design❣️
cc @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-883436924
> 4. Click to expand and show all tags as an option
@kicaak btw, as @junlincc said the fourth point, I'm not sure if there is an "all tags" button to collapse and expand all tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7afd96) into [master](https://codecov.io/gh/apache/superset/commit/0721f54580426c4f53902c59067438adf30d5955?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0721f54) will **increase** coverage by `0.01%`.
> The diff coverage is `67.39%`.
> :exclamation: Current head a7afd96 differs from pull request most recent head 45cf61f. Consider uploading reports for the commit 45cf61f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
==========================================
+ Coverage 76.91% 76.92% +0.01%
==========================================
Files 983 983
Lines 51602 51625 +23
Branches 6980 6990 +10
==========================================
+ Hits 39688 39714 +26
+ Misses 11691 11687 -4
- Partials 223 224 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.38% <67.39%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...onalFormattingControl/FormattingPopoverContent.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=) | `33.33% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `64.44% <59.09%> (+4.44%)` | :arrow_up: |
| [...ols/DndColumnSelectControl/utils/optionSelector.ts](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3V0aWxzL29wdGlvblNlbGVjdG9yLnRz) | `46.15% <66.66%> (+11.67%)` | :arrow_up: |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.23% <77.77%> (+0.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0721f54...45cf61f](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ edited a comment on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
stephenLYZ edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881473784
Maybe I think `popular` only needs to be set to default if you are creating a chart instead of opening a chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on a change in pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on a change in pull request #15734:
URL: https://github.com/apache/superset/pull/15734#discussion_r671270942
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -220,6 +224,11 @@ const DetailsEmpty = (theme: SupersetTheme) => css`
// overflow hidden on the details pane and overflow auto on the description
// (plus grid layout) enables the description to scroll while the header stays in place.
+const TagsWrapper = styled.div`
+ grid-area: viz-tags;
+ width: ${({ theme }) => theme.gridUnit * 120}px;
+ padding-right: ${({ theme }) => theme.gridUnit * 14}px;
+`;
Review comment:
add: padding-bottom: ${({ theme }) => theme.gridUnit * 2}px;
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -220,6 +224,11 @@ const DetailsEmpty = (theme: SupersetTheme) => css`
// overflow hidden on the details pane and overflow auto on the description
// (plus grid layout) enables the description to scroll while the header stays in place.
+const TagsWrapper = styled.div`
+ grid-area: viz-tags;
+ width: ${({ theme }) => theme.gridUnit * 120}px;
+ padding-right: ${({ theme }) => theme.gridUnit * 14}px;
+`;
Review comment:
Add: padding-bottom: ${({ theme }) => theme.gridUnit * 2}px;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c89eeb5) into [master](https://codecov.io/gh/apache/superset/commit/069d5cb6a42aa0d2c5ddd99dc68fd2f50ef00975?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (069d5cb) will **increase** coverage by `0.00%`.
> The diff coverage is `78.94%`.
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
=======================================
Coverage 76.69% 76.70%
=======================================
Files 983 983
Lines 51609 51641 +32
Branches 6988 6996 +8
=======================================
+ Hits 39580 39609 +29
- Misses 11806 11808 +2
- Partials 223 224 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.39% <78.94%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.26% <78.94%> (+0.69%)` | :arrow_up: |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `80.72% <0.00%> (-0.62%)` | :arrow_down: |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `64.58% <0.00%> (+0.13%)` | :arrow_up: |
| [.../controls/DndColumnSelectControl/OptionWrapper.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbldyYXBwZXIudHN4) | `85.29% <0.00%> (+0.44%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [069d5cb...c89eeb5](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882727364
@ktmud @suddjian @rusackas all UI/UX comments are accepted, thank you for your suggestion!
Based on your input, below mockup will be implemented in next iteration.
1. To relocate the search bar to main section
2. Search to take up the entire row
3. Stack tags above category list, only display 3-4 tags in the list
4. Click to expand and show all tags as an option
Many thanks to a freelance product designer for contributing this design❣️
cc @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881706656
depends on the entry point, @ktmud
https://user-images.githubusercontent.com/67837651/126006312-841b2982-5a4e-4705-81db-c0a886bf727f.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881417059
It is very confusing to be honest. You see thr information of the selected viz type at the bottom, a search value that you didn't search for and some viz types but not the actual one that is selected.
This is the second time that I end up thinking this is a bug.
CC @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881387836
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on a change in pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on a change in pull request #15734:
URL: https://github.com/apache/superset/pull/15734#discussion_r671271150
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -206,6 +209,7 @@ const DetailsPopulated = (theme: SupersetTheme) => css`
grid-template-rows: auto 1fr;
Review comment:
Modified: grid-template-rows: auto auto 1fr;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881397611
Hey @zhaoyongjie. Thanks for the PR.
I think we should not set `Popular` as default. When opening the modal with an existing viz type, only the footer is showing the right type information now. I would expect to see the selected viz type and related category as well.
<img width="1133" alt="Screen Shot 2021-07-16 at 14 01 09" src="https://user-images.githubusercontent.com/60598000/125944665-d8855b68-680b-49c1-b9a1-8e85b99d7464.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-883364420
@kicaak Thanks for providing the design file, it will be helpful for the next iteration.😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882287403
> > An unrelated design question, does anyone else find the position of the search input weird? It looks like a search for the viz category list, not the viz types.
>
>
>
> Not to me, really... it's easy to point at other successful UIs that do this, e.g. the Mac App Store:
>
> 
>
>
>
> or other apps (Spotify, Notion, in this case) that at least put the affordance in that area.
>
> 
>
>
Except these examples do not evoke reminiscence of a regular autocomplete combobox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881627200
An unrelated design question, does anyone else find the position of the search input weird? It looks like a search for the viz category list, not the viz types.
In the original design (https://github.com/apache/superset/issues/14474), it is a fullwidth search bar at the top, which makes much more sense visually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] xiezhongfu edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
xiezhongfu edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881856309
* Perhaps it's worth making `viztype-selector list` have the ability to scroll.
* When Search-Input value is `Popular `, hope the `Popular` tag in the tags list is selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882727364
@ktmud @suddjian @rusackas all UI/UX comments are accepted, thank you for your suggestion!
Based on your input, below mockup will be implemented in next iteration.
1. To relocate the search bar to main section
2. Search to take up the entire row
3. Stack tags above category list, only display 3-4 tags in the list
4. Click to expand and show all tags as an option
Many thanks to a freelance product designer for contributing this design❣️
cc @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881408917
> Hey @zhaoyongjie. Thanks for the PR.
>
> I think we should not set `Popular` as default. When opening the modal with an existing viz type, only the footer is showing the right type information now. I would expect to see the selected viz type and related category as well.
>
> <img alt="Screen Shot 2021-07-16 at 14 01 09" width="1133" src="https://user-images.githubusercontent.com/60598000/125944665-d8855b68-680b-49c1-b9a1-8e85b99d7464.png">
Hi, @geido. This behavior is by product design. please check here https://github.com/apache/superset/projects/30
I also wonder, why there is a chart here without the `popular` tag.
If this change is approved by @junlincc. I will continue to tweak the search logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-884424670
@stephenLYZ we do have a "all tags and categories" to expand. but in this case, it should be "all tags" only
@kicaak i think we will need an icon or something,,, to collapse the long tag list as well. do you mind providing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7afd96) into [master](https://codecov.io/gh/apache/superset/commit/0721f54580426c4f53902c59067438adf30d5955?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0721f54) will **increase** coverage by `0.01%`.
> The diff coverage is `67.39%`.
> :exclamation: Current head a7afd96 differs from pull request most recent head 6f4de3f. Consider uploading reports for the commit 6f4de3f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
==========================================
+ Coverage 76.91% 76.92% +0.01%
==========================================
Files 983 983
Lines 51602 51625 +23
Branches 6980 6990 +10
==========================================
+ Hits 39688 39714 +26
+ Misses 11691 11687 -4
- Partials 223 224 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.38% <67.39%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...onalFormattingControl/FormattingPopoverContent.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=) | `33.33% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `64.44% <59.09%> (+4.44%)` | :arrow_up: |
| [...ols/DndColumnSelectControl/utils/optionSelector.ts](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3V0aWxzL29wdGlvblNlbGVjdG9yLnRz) | `46.15% <66.66%> (+11.67%)` | :arrow_up: |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.23% <77.77%> (+0.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0721f54...6f4de3f](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881617368
Hi @stephenLYZ, @geido, and @suddjian, I have updated the tags filter. please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c62636f) into [master](https://codecov.io/gh/apache/superset/commit/0721f54580426c4f53902c59067438adf30d5955?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0721f54) will **increase** coverage by `0.00%`.
> The diff coverage is `69.23%`.
> :exclamation: Current head c62636f differs from pull request most recent head c839b3d. Consider uploading reports for the commit c839b3d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 983 983
Lines 51602 51613 +11
Branches 6980 6982 +2
=======================================
+ Hits 39688 39699 +11
+ Misses 11691 11690 -1
- Partials 223 224 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.35% <69.23%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.03% <69.23%> (+0.46%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0721f54...c839b3d](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882015557
> An unrelated design question, does anyone else find the position of the search input weird? It looks like a search for the viz category list, not the viz types.
Not to me, really... it's easy to point at other successful UIs that do this, e.g. the Mac App Store:
or other apps (Spotify, Notion, in this case) that at least put the affordance in that area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-883267264
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881365502
# [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15734](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45cf61f) into [master](https://codecov.io/gh/apache/superset/commit/0721f54580426c4f53902c59067438adf30d5955?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0721f54) will **increase** coverage by `0.01%`.
> The diff coverage is `78.94%`.
[](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15734 +/- ##
==========================================
+ Coverage 76.91% 76.92% +0.01%
==========================================
Files 983 983
Lines 51602 51626 +24
Branches 6980 6990 +10
==========================================
+ Hits 39688 39715 +27
+ Misses 11691 11687 -4
- Partials 223 224 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.38% <78.94%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.26% <78.94%> (+0.69%)` | :arrow_up: |
| [...onalFormattingControl/FormattingPopoverContent.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db25kaXRpb25hbEZvcm1hdHRpbmdDb250cm9sL0Zvcm1hdHRpbmdQb3BvdmVyQ29udGVudC50c3g=) | `33.33% <0.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `64.44% <0.00%> (+4.44%)` | :arrow_up: |
| [...ols/DndColumnSelectControl/utils/optionSelector.ts](https://codecov.io/gh/apache/superset/pull/15734/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL3V0aWxzL29wdGlvblNlbGVjdG9yLnRz) | `46.15% <0.00%> (+11.67%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0721f54...45cf61f](https://codecov.io/gh/apache/superset/pull/15734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882287403
> > An unrelated design question, does anyone else find the position of the search input weird? It looks like a search for the viz category list, not the viz types.
>
>
>
> Not to me, really... it's easy to point at other successful UIs that do this, e.g. the Mac App Store:
>
> 
>
>
>
> or other apps (Spotify, Notion, in this case) that at least put the affordance in that area.
>
> 
>
>
Except these examples do not evoke reminiscence of a regular autocomplete combobox.
Maybe it'd solve my OCD if there are less categories and they all have icons (so they look more like tabs instead of menu items under a searchbox).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881709295
Order for searchable/clickable tags in Gallery
1. Change “Popular” to “Highly-used”
2. Highly-used, ECharts, Geo, Advanced-Analytics, Report, Experimental, Tabular, Relational, Proportional, Progressive, Sequential, Circular, Predictive, Statistical, Transformable, Description, Comparison, Popularity, Distribution, Aesthetic, 2D, 3D
Keep all tags in one row, click or scroll to view more
Please also make sure the clickable tags are in the gallery modal from the main entry point, which is from the "+" icon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881714729
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15734: chore: Add tags to the new viz gallery
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-882727364
@ktmud @suddjian @rusackas all UI/UX comments are accepted, thank you for your suggestion!
Based on your input, below mockup will be implemented in next iteration.
1. To relocate the search bar to main section
2. Search to take up the entire row
3. Stack tags above category list, only display 3-4 tags in the list
4. Click to expand and show all tags as an option
Many thanks to a freelance product designer for contributing this design❣️
cc @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881408917
> Hey @zhaoyongjie. Thanks for the PR.
>
> I think we should not set `Popular` as default. When opening the modal with an existing viz type, only the footer is showing the right type information now. I would expect to see the selected viz type and related category as well.
>
> <img alt="Screen Shot 2021-07-16 at 14 01 09" width="1133" src="https://user-images.githubusercontent.com/60598000/125944665-d8855b68-680b-49c1-b9a1-8e85b99d7464.png">
Hi, @geido. This behavior is by product design. please check here `https://github.com/apache/superset/projects/30`.
I also wonder, why there is a chart here without the `popular` tag.
If this change is approved by @junlincc. I will continue to tweak the search logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15734: chore: Add tags to the new viz gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881709295
Order for searchable/clickable tags in Gallery
1. Change “Popular” to “Highly-used” per Max,
2. Highly-used, ECharts, Geo, Advanced-Analytics, Report, Experimental, Tabular, Relational, Proportional, Progressive, Sequential, Circular, Predictive, Statistical, Transformable, Description, Comparison, Popularity, Distribution, Aesthetic, 2D, 3D
Keep all tags in one row, click or scroll to view more
Please also make sure the clickable tags are in the gallery modal from the main entry point, which is from the "+" icon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido edited a comment on pull request #15734: chore: Add tags to gallery(iteration 1)
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #15734:
URL: https://github.com/apache/superset/pull/15734#issuecomment-881417059
It is very confusing to be honest. You see the information of the selected viz type at the bottom, a search value that you didn't search for and some viz types but not the actual one that was selected.
This is the second time that I end up thinking this is a bug.
CC @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org