[GitHub] [airflow] kaxil commented on a diff in pull request #27856: Change log level to info when secret not found for google secret manager

[GitBox <gi...@apache.org>]

kaxil commented on code in PR #27856:
URL: https://github.com/apache/airflow/pull/27856#discussion_r1030922100


##########
airflow/providers/google/cloud/_internal_client/secret_manager_client.py:
##########
@@ -75,7 +75,7 @@ def get_secret(self, secret_id: str, project_id: str, secret_version: str = "lat
             value = response.payload.data.decode("UTF-8")
             return value
         except NotFound:
-            self.log.error("Google Cloud API Call Error (NotFound): Secret ID %s not found.", secret_id)
+            self.log.info("Google Cloud API Call Error (NotFound): Secret ID %s not found.", secret_id)

Review Comment:
   I would be in favor of even making it debug like AWS's secrets backend:
   
   https://github.com/apache/airflow/blob/1486afdc9f3855e80f475dcaa2adc729faf3bd08/airflow/providers/amazon/aws/secrets/systems_manager.py#L183



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org