You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/06/09 21:05:28 UTC
Review Request 35262: Logged framework capabilities during
(re-)registration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35262/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2804
https://issues.apache.org/jira/browse/MESOS-2804
Repository: mesos
Description
-------
See MESOS-2804 for the motivation.
Diffs
-----
include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b
src/master/master.cpp e91e8815471b49d3c649470197d6da3f06de62fb
Diff: https://reviews.apache.org/r/35262/diff/
Testing
-------
Ran the oversubscription tests to verify the output:
```
I0609 19:01:02.855468 13605 master.cpp:1783] Registering framework 20150609-190102-1828659978-38362-13474-0000 (default) at scheduler-73035a36-e16a-4bdb-ae4c-992c6b3694fa@10.35.255.108:38362 with checkpointing disabled and capabilities [ REVOCABLE_RESOURCES ]
```
Thanks,
Ben Mahler
Re: Review Request 35262: Logged framework capabilities during
(re-)registration.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35262/#review87281
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35262]
All tests passed.
- Mesos ReviewBot
On June 9, 2015, 7:05 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35262/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 7:05 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2804
> https://issues.apache.org/jira/browse/MESOS-2804
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-2804 for the motivation.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b
> src/master/master.cpp e91e8815471b49d3c649470197d6da3f06de62fb
>
> Diff: https://reviews.apache.org/r/35262/diff/
>
>
> Testing
> -------
>
> Ran the oversubscription tests to verify the output:
>
> ```
> I0609 19:01:02.855468 13605 master.cpp:1783] Registering framework 20150609-190102-1828659978-38362-13474-0000 (default) at scheduler-73035a36-e16a-4bdb-ae4c-992c6b3694fa@10.35.255.108:38362 with checkpointing disabled and capabilities [ REVOCABLE_RESOURCES ]
> ```
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 35262: Logged framework capabilities during
(re-)registration.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35262/#review87294
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On June 9, 2015, 7:05 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35262/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 7:05 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2804
> https://issues.apache.org/jira/browse/MESOS-2804
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-2804 for the motivation.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b
> src/master/master.cpp e91e8815471b49d3c649470197d6da3f06de62fb
>
> Diff: https://reviews.apache.org/r/35262/diff/
>
>
> Testing
> -------
>
> Ran the oversubscription tests to verify the output:
>
> ```
> I0609 19:01:02.855468 13605 master.cpp:1783] Registering framework 20150609-190102-1828659978-38362-13474-0000 (default) at scheduler-73035a36-e16a-4bdb-ae4c-992c6b3694fa@10.35.255.108:38362 with checkpointing disabled and capabilities [ REVOCABLE_RESOURCES ]
> ```
>
>
> Thanks,
>
> Ben Mahler
>
>