(iceberg-go) branch main updated: test: cover the case-insensitive branch of splitLineageMetadataFields (#1281)

[at...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

laskoviymishka pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-go.git


The following commit(s) were added to refs/heads/main by this push:
     new ca459f92 test: cover the case-insensitive branch of splitLineageMetadataFields (#1281)
ca459f92 is described below

commit ca459f92a6c644c1684cca922bf2e311fd723bd5
Author: Ahmed Dlshad <ah...@gmail.com>
AuthorDate: Wed Jun 24 15:18:14 2026 +0300

    test: cover the case-insensitive branch of splitLineageMetadataFields (#1281)
    
    ## What
    
    Adds a table-driven `TestSplitLineageMetadataFields` covering the
    previously-untested `caseSensitive == false` branch of
    `splitLineageMetadataFields` (`table/scanner.go`), as requested in
    #1275.
    
    `splitLineageMetadataFields` matches `_row_id` /
    `_last_updated_sequence_number` via `strings.EqualFold` when
    `caseSensitive` is false, but every existing `Scan` test sets
    `caseSensitive: true`, so that branch was never exercised.
    
    The new test asserts:
    
    - **case-insensitive:** mixed-case `_ROW_ID` and
    `_Last_Updated_Sequence_Number` are routed into the lineage fields;
    - **case-sensitive control:** the same mixed-case names fall through to
    user fields;
    - **case-sensitive:** exact lineage column names still match.
    
    No production code changes; test-only.
    
    Closes #1275
    
    Signed-off-by: Ahmed <ah...@gmail.com>
---
 table/scanner_internal_test.go | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/table/scanner_internal_test.go b/table/scanner_internal_test.go
index acaf3531..73b2bc59 100644
--- a/table/scanner_internal_test.go
+++ b/table/scanner_internal_test.go
@@ -113,6 +113,46 @@ func TestMinSequenceNum(t *testing.T) {
 	}
 }
 
+func TestSplitLineageMetadataFields(t *testing.T) {
+	tests := []struct {
+		name          string
+		selected      []string
+		caseSensitive bool
+		wantUser      []string
+		wantLineage   []iceberg.NestedField
+	}{
+		{
+			name:          "case-insensitive matches mixed-case lineage columns",
+			selected:      []string{"id", "_ROW_ID", "_Last_Updated_Sequence_Number"},
+			caseSensitive: false,
+			wantUser:      []string{"id"},
+			wantLineage:   []iceberg.NestedField{iceberg.RowID(), iceberg.LastUpdatedSequenceNumber()},
+		},
+		{
+			name:          "case-sensitive leaves mixed-case names as user fields",
+			selected:      []string{"id", "_ROW_ID", "_Last_Updated_Sequence_Number"},
+			caseSensitive: true,
+			wantUser:      []string{"id", "_ROW_ID", "_Last_Updated_Sequence_Number"},
+			wantLineage:   nil,
+		},
+		{
+			name:          "case-sensitive matches exact lineage column names",
+			selected:      []string{"id", iceberg.RowIDColumnName, iceberg.LastUpdatedSequenceNumberColumnName},
+			caseSensitive: true,
+			wantUser:      []string{"id"},
+			wantLineage:   []iceberg.NestedField{iceberg.RowID(), iceberg.LastUpdatedSequenceNumber()},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			userFields, lineageFields := splitLineageMetadataFields(tt.selected, tt.caseSensitive)
+			assert.Equal(t, tt.wantUser, userFields)
+			assert.Equal(t, tt.wantLineage, lineageFields)
+		})
+	}
+}
+
 func TestKeyDefaultMapRaceCondition(t *testing.T) {
 	var factoryCallCount atomic.Int64
 	factory := func(key string) int {