You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2023/04/11 10:54:51 UTC
[camel] branch main updated: Replaced string concatenation in loop with StringJoiner. PR for core (#9843)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new f0e54bf0707 Replaced string concatenation in loop with StringJoiner. PR for core (#9843)
f0e54bf0707 is described below
commit f0e54bf07075c6aa5fb3a7838e2d25d28349309f
Author: dk2k <dk...@users.noreply.github.com>
AuthorDate: Tue Apr 11 13:54:42 2023 +0300
Replaced string concatenation in loop with StringJoiner. PR for core (#9843)
Co-authored-by: dk2k <dk...@ya.ru>
---
.../camel/main/MainConfigurationProperties.java | 27 +++++++++-------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/core/camel-main/src/main/java/org/apache/camel/main/MainConfigurationProperties.java b/core/camel-main/src/main/java/org/apache/camel/main/MainConfigurationProperties.java
index 7475119eb57..42901939812 100644
--- a/core/camel-main/src/main/java/org/apache/camel/main/MainConfigurationProperties.java
+++ b/core/camel-main/src/main/java/org/apache/camel/main/MainConfigurationProperties.java
@@ -18,6 +18,7 @@ package org.apache.camel.main;
import java.util.ArrayList;
import java.util.List;
+import java.util.StringJoiner;
import org.apache.camel.CamelConfiguration;
import org.apache.camel.RoutesBuilder;
@@ -376,19 +377,16 @@ public class MainConfigurationProperties extends DefaultConfigurationProperties<
*/
@SuppressWarnings("unchecked")
private void addConfigurationClass(Class<? extends CamelConfiguration>... configuration) {
- String existing = configurationClasses;
- if (existing == null) {
- existing = "";
+ StringJoiner existing = new StringJoiner(",");
+ if (configurationClasses != null && !configurationClasses.isEmpty()) {
+ existing.add(configurationClasses);
}
if (configuration != null) {
for (Class<? extends CamelConfiguration> clazz : configuration) {
- if (!existing.isEmpty()) {
- existing = existing + ",";
- }
- existing = existing + clazz.getName();
+ existing.add(clazz.getName());
}
}
- setConfigurationClasses(existing);
+ setConfigurationClasses(existing.toString());
}
/**
@@ -452,19 +450,16 @@ public class MainConfigurationProperties extends DefaultConfigurationProperties<
* Add an additional {@link RoutesBuilder} class to the known list of builders.
*/
public void addRoutesBuilder(Class<?>... routeBuilder) {
- String existing = routesBuilderClasses;
- if (existing == null) {
- existing = "";
+ StringJoiner existing = new StringJoiner(",");
+ if (routesBuilderClasses != null && !routesBuilderClasses.isEmpty()) {
+ existing.add(routesBuilderClasses);
}
if (routeBuilder != null) {
for (Class<?> clazz : routeBuilder) {
- if (!existing.isEmpty()) {
- existing = existing + ",";
- }
- existing = existing + clazz.getName();
+ existing.add(clazz.getName());
}
}
- setRoutesBuilderClasses(existing);
+ setRoutesBuilderClasses(existing.toString());
}
/**