[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20043#discussion_r169223570
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala ---
    @@ -75,7 +75,7 @@ case class BoundReference(ordinal: Int, dataType: DataType, nullable: Boolean)
                  |$javaType ${ev.value} = ${ev.isNull} ? ${ctx.defaultValue(dataType)} : ($value);
                """.stripMargin)
           } else {
    -        ev.copy(code = s"$javaType ${ev.value} = $value;", isNull = "false")
    +        ev.copy(code = s"$javaType ${ev.value} = $value;", isNull = LiteralValue("false"))
    --- End diff --
    
    nit: shall we introduce a `TrueLiteral` and `FalseLiteral`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org