[GitHub] spark pull request #14921: [SPARK-17361][SQL] file-based external table with...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14921#discussion_r77292804
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
    @@ -314,12 +314,8 @@ case class DataSource(
       /**
        * Create a resolved [[BaseRelation]] that can be used to read data from or write data into this
        * [[DataSource]]
    -   *
    -   * @param checkPathExist A flag to indicate whether to check the existence of path or not.
    -   *                       This flag will be set to false when we create an empty table (the
    -   *                       path of the table does not exist).
        */
    -  def resolveRelation(checkPathExist: Boolean = true): BaseRelation = {
    +  def resolveRelation(): BaseRelation = {
    --- End diff --
    
    Based on my understanding, `resolveRelation` is not invoked by the write path of the non-file based data sources. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org