You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/09 06:45:46 UTC
[GitHub] [incubator-kvrocks] tisonkun opened a new issue, #559: Remove unused and misleading variable `kDefaultConfPath`
tisonkun opened a new issue, #559:
URL: https://github.com/apache/incubator-kvrocks/issues/559
https://github.com/apache/incubator-kvrocks/blob/a5a5434a93388137be640c55b5440a66f42e1659/src/main.cc#L48
It seems we don't actually load config from `../kvrocks.conf` if `-c` is not specific.
cc @git-hulk @ShooterIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #559: Remove unused and misleading variable `kDefaultConfPath`
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #559:
URL: https://github.com/apache/incubator-kvrocks/issues/559#issuecomment-1120849480
@ShooterIT Kvrocks had supported that, so the default path was unused actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #559: Remove unused and misleading variable `kDefaultConfPath`
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #559:
URL: https://github.com/apache/incubator-kvrocks/issues/559#issuecomment-1125648721
I'm going to prepare a patch to remove related code later today :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #559: Remove unused and misleading variable `kDefaultConfPath`
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #559:
URL: https://github.com/apache/incubator-kvrocks/issues/559#issuecomment-1120708741
Yes, u are right. It won't use this default config path any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun closed issue #559: Remove unused and misleading variable `kDefaultConfPath`
Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #559: Remove unused and misleading variable `kDefaultConfPath`
URL: https://github.com/apache/incubator-kvrocks/issues/559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] ShooterIT commented on issue #559: Remove unused and misleading variable `kDefaultConfPath`
Posted by GitBox <gi...@apache.org>.
ShooterIT commented on issue #559:
URL: https://github.com/apache/incubator-kvrocks/issues/559#issuecomment-1120846883
Current solution is not a good idea. But i think kvrocks should provide a way to start without conf file. i.e. without `-c xxx.conf`, this makes it easy to try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #559: Remove unused and misleading variable `kDefaultConfPath`
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #559:
URL: https://github.com/apache/incubator-kvrocks/issues/559#issuecomment-1125934127
FYI I record the experience to solve this issue on bilibili: https://www.bilibili.com/video/BV1w54y1Z7VP/
It may be a content to show how to participant Kvrocks community :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org