You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ec...@apache.org on 2019/10/24 10:08:41 UTC
[beam] 17/37: Fix equal and hashcode
This is an automated email from the ASF dual-hosted git repository.
echauchot pushed a commit to branch spark-runner_structured-streaming
in repository https://gitbox.apache.org/repos/asf/beam.git
commit f48067b87be26773de91d076c4ad249f54890db0
Author: Etienne Chauchot <ec...@apache.org>
AuthorDate: Thu Sep 5 14:49:37 2019 +0200
Fix equal and hashcode
---
.../structuredstreaming/translation/helpers/EncoderHelpers.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/helpers/EncoderHelpers.java b/runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/helpers/EncoderHelpers.java
index 83243b3..91aaaf9 100644
--- a/runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/helpers/EncoderHelpers.java
+++ b/runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/helpers/EncoderHelpers.java
@@ -195,11 +195,11 @@ public class EncoderHelpers {
return false;
}
EncodeUsingBeamCoder<?> that = (EncodeUsingBeamCoder<?>) o;
- return beamCoder.equals(that.beamCoder);
+ return beamCoder.equals(that.beamCoder) && child.equals(that.child);
}
@Override public int hashCode() {
- return Objects.hash(super.hashCode(), beamCoder);
+ return Objects.hash(super.hashCode(), child, beamCoder);
}
}
@@ -306,11 +306,11 @@ public class EncoderHelpers {
return false;
}
DecodeUsingBeamCoder<?> that = (DecodeUsingBeamCoder<?>) o;
- return classTag.equals(that.classTag) && beamCoder.equals(that.beamCoder);
+ return child.equals(that.child) && classTag.equals(that.classTag) && beamCoder.equals(that.beamCoder);
}
@Override public int hashCode() {
- return Objects.hash(super.hashCode(), classTag, beamCoder);
+ return Objects.hash(super.hashCode(), child, classTag, beamCoder);
}
}
}