You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/27 00:45:21 UTC
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #7138: Injectable statsd client
john-bodley commented on a change in pull request #7138: Injectable statsd client
URL: https://github.com/apache/incubator-superset/pull/7138#discussion_r269370012
##########
File path: tox.ini
##########
@@ -51,9 +51,6 @@ commands =
deps =
-rrequirements.txt
-rrequirements-dev.txt
- coverage
Review comment:
I think `requirements-dev.txt` has simply grown to contain more than just the base requirements. If coverage will only be run as part of the CI then it makes sense to have it in `tox.ini` otherwise `requirements-dev.txt` makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org