You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/01 18:31:00 UTC
[jira] [Commented] (GEODE-3283) Add gfsh option on export/import to
parallelize a snapshot for PRs
[ https://issues.apache.org/jira/browse/GEODE-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150979#comment-16150979 ]
ASF GitHub Bot commented on GEODE-3283:
---------------------------------------
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136638047
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java ---
@@ -41,44 +44,34 @@ public Result exportData(
@CliOption(key = CliStrings.EXPORT_DATA__REGION, mandatory = true,
optionContext = ConverterHint.REGION_PATH,
help = CliStrings.EXPORT_DATA__REGION__HELP) String regionName,
- @CliOption(key = CliStrings.EXPORT_DATA__FILE, mandatory = true,
+ @CliOption(key = CliStrings.EXPORT_DATA__FILE,
help = CliStrings.EXPORT_DATA__FILE__HELP) String filePath,
+ @CliOption(key = CliStrings.EXPORT_DATA__DIR,
+ help = CliStrings.EXPORT_DATA__DIR__HELP) String dirPath,
@CliOption(key = CliStrings.MEMBER, optionContext = ConverterHint.MEMBERIDNAME,
- mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP) String memberNameOrId) {
+ mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP) String memberNameOrId,
+ @CliOption(key = CliStrings.EXPORT_DATA__PARALLEL, unspecifiedDefaultValue = "false",
--- End diff --
also, since there is a unspecified default value (false), is it really necessary to make it a mandatory option if "dir" is specified? can we just make it default to false(or true, whatever sensible) if user didn't add --parallel, but specified --dir?
> Add gfsh option on export/import to parallelize a snapshot for PRs
> ------------------------------------------------------------------
>
> Key: GEODE-3283
> URL: https://issues.apache.org/jira/browse/GEODE-3283
> Project: Geode
> Issue Type: Sub-task
> Components: snapshot
> Reporter: Fred Krone
> Assignee: Nick Reich
>
> This is related to another ticket to improve snapshot export time
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)