[GitHub] [iceberg] Fokko commented on a diff in pull request #6775: Python: Add positional deletes

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #6775:
URL: https://github.com/apache/iceberg/pull/6775#discussion_r1128352920


##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -512,6 +546,28 @@ def _file_to_table(
             columns=[col.name for col in file_project_schema.columns],
         )
 
+        if positional_deletes is not None:
+            # When there are positional deletes, create a filter mask
+            # there is room for optimization here, maybe we can sort
+            # them earlier at insertion, but then you might need to do
+            # additional copying
+            sorted_deleted = iter(positional_deletes.combine_chunks().sort())

Review Comment:
   This is horrible, a better way of doing this is incoming.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org