[GitHub] [arrow] bkietz commented on a change in pull request #8311: ARROW-10008: [C++][Dataset] Fix filtering/row group statistics of dict columns

[GitBox <gi...@apache.org>]

bkietz commented on a change in pull request #8311:
URL: https://github.com/apache/arrow/pull/8311#discussion_r498953710



##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -171,6 +170,15 @@ static std::shared_ptr<StructScalar> ColumnChunkStatisticsAsStructScalar(
     return nullptr;
   }
 
+  auto maybe_min = min->CastTo(field->type());
+  auto maybe_max = max->CastTo(field->type());

Review comment:
       `StatisticsAsScalars` returns scalars whose types are the correct *physical type*, so even if the column was `dictionary(string)` min and max would be just `string` before this cast




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org