[GitHub] [kafka] venkatteki commented on a change in pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified

[GitBox <gi...@apache.org>]

venkatteki commented on a change in pull request #11615:
URL: https://github.com/apache/kafka/pull/11615#discussion_r787676776



##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceConnectorConfigTest.java
##########
@@ -64,6 +67,18 @@
         return props;
     }
 
+    @Test
+    public void shouldNotFailWithExplicitlySpecifiedDefaultTopicCreationGroup() {
+        Map<String, String> props = defaultConnectorProps();
+        //Ensure default group is omitted even if its specified multiple times.
+        props.put(TOPIC_CREATION_GROUPS_CONFIG, String.join(",", DEFAULT_TOPIC_CREATION_GROUP,
+            TOPIC_CREATION_GROUP_1, DEFAULT_TOPIC_CREATION_GROUP, TOPIC_CREATION_GROUP_2));
+        props.put(TOPIC_CREATION_GROUPS_CONFIG, DEFAULT_TOPIC_CREATION_GROUP);

Review comment:
       > Was this left in accidentally? Looks like it overrides the line above, which seems more suitable for this test case.
   
   Thanks for catching it! fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org