[GitHub] spark pull request: [SPARK-11433] [SQL] Cleanup the subquery name ...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9385#discussion_r43608157
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ---
    @@ -1019,7 +1019,16 @@ class Analyzer(
      * scoping information for attributes and can be removed once analysis is complete.
      */
     object EliminateSubQueries extends Rule[LogicalPlan] {
    -  def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    +  def apply(plan: LogicalPlan): LogicalPlan = plan transformDown {
    +    case Project(projectList, child: Subquery) => {
    +      Project(
    +        projectList.flatMap {
    --- End diff --
    
    Could we simplify this to a map and remove the :: Nil we have in the two sub cases? since it seems we are always returning a single element list for every case so it 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org