You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/23 07:42:03 UTC
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request
#4415: Move table segment handling from parser to token generator
tristaZero opened a new pull request #4415: Move table segment handling from parser to token generator
URL: https://github.com/apache/incubator-shardingsphere/pull/4415
Fixes #4390 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4415:
Move table segment handling from parser to token generator
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4415: Move table segment handling from parser to token generator
URL: https://github.com/apache/incubator-shardingsphere/pull/4415#issuecomment-590037635
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@896c857`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `57.95%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4415 +/- ##
=========================================
Coverage ? 54.97%
Complexity ? 332
=========================================
Files ? 953
Lines ? 18473
Branches ? 3413
=========================================
Hits ? 10156
Misses ? 7661
Partials ? 656
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...here/sql/parser/PostgreSQLParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvUG9zdGdyZVNRTFBhcnNlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...l/parser/core/visitor/ParseTreeVisitorFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvUGFyc2VUcmVlVmlzaXRvckZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ingsphere/sql/parser/MySQLParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMUGFyc2VyQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ingsphere/sql/parser/SQL92ParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL1NRTDkyUGFyc2VyQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...phere/sql/parser/SQLServerParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbHNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9TUUxTZXJ2ZXJQYXJzZXJDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ngsphere/sql/parser/OracleParserConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9PcmFjbGVQYXJzZXJDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ere/sql/parser/sql/statement/SQLStatementType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc3RhdGVtZW50L1NRTFN0YXRlbWVudFR5cGUuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...rdingsphere/sql/parser/core/constant/RuleName.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2NvbnN0YW50L1J1bGVOYW1lLmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415?src=pr&el=footer). Last update [896c857...cd6baaf](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4415?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4415: Move table segment handling from parser to token generator
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4415: Move table segment handling from parser to token generator
URL: https://github.com/apache/incubator-shardingsphere/pull/4415#issuecomment-590037829
## Pull Request Test Coverage Report for [Build 1842](https://coveralls.io/builds/28901782)
* **22** of **29** **(75.86%)** changed or added relevant lines in **2** files are covered.
* **4** unchanged lines in **4** files lost coverage.
* Overall coverage increased (+**0.3%**) to **58.599%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28901782/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L139) | 0 | 3 | 0.0%
| [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java](https://coveralls.io/builds/28901782/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FTableTokenGenerator.java#L128) | 22 | 26 | 84.62%
<!-- | **Total:** | **22** | **29** | **75.86%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28901782/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L271) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28901782/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L277) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28901782/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L241) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28901782/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L266) | 1 | 0% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/28901782) |
| :-- | --: |
| Change from base [Build 908](https://coveralls.io/builds/28901678): | 0.3% |
| Covered Lines: | 10825 |
| Relevant Lines: | 18473 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4415:
Move table segment handling from parser to token generator
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4415: Move table segment handling from parser to token generator
URL: https://github.com/apache/incubator-shardingsphere/pull/4415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4415: Move
table segment handling from parser to token generator
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4415: Move table segment handling from parser to token generator
URL: https://github.com/apache/incubator-shardingsphere/pull/4415#issuecomment-590037829
## Pull Request Test Coverage Report for [Build 9717](https://coveralls.io/builds/28901777)
* **22** of **29** **(75.86%)** changed or added relevant lines in **2** files are covered.
* **7** unchanged lines in **5** files lost coverage.
* Overall coverage increased (+**0.3%**) to **58.594%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28901777/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L139) | 0 | 3 | 0.0%
| [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java](https://coveralls.io/builds/28901777/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FTableTokenGenerator.java#L128) | 22 | 26 | 84.62%
<!-- | **Total:** | **22** | **29** | **75.86%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java](https://coveralls.io/builds/28901777/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDMLVisitor.java#L271) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/28901777/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L277) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://coveralls.io/builds/28901777/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQL92DMLVisitor.java#L241) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/28901777/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L266) | 1 | 0% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28901777/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **7** | | -->
| Totals | [](https://coveralls.io/builds/28901777) |
| :-- | --: |
| Change from base [Build 908](https://coveralls.io/builds/28901678): | 0.3% |
| Covered Lines: | 10824 |
| Relevant Lines: | 18473 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services