[GitHub] [flink] pnowojski commented on a change in pull request #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush.

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #9706: [FLINK-14118][runtime]Reduce the unnecessary flushing when there is no data available for flush.
URL: https://github.com/apache/flink/pull/9706#discussion_r326623064
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferConsumer.java
 ##########
 @@ -163,6 +170,10 @@ public int getCached() {
 			return PositionMarker.getAbsolute(cachedPosition);
 		}
 
+		private int getLatest() {
+			return PositionMarker.getAbsolute(positionMarker.get());
 
 Review comment:
   This is adding new synchronisation point (`volatile` read) and will probably decrease performance in low latency or huge clusters high throughput scenarios.
   
   Let me think a bit about this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services