You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mike Youngstrom (JIRA)" <my...@incubator.apache.org> on 2005/07/23 02:04:45 UTC
[jira] Created: (MYFACES-356) AddResource.writeWithFullHeader() writing old header twice
AddResource.writeWithFullHeader() writing old header twice
----------------------------------------------------------
Key: MYFACES-356
URL: http://issues.apache.org/jira/browse/MYFACES-356
Project: MyFaces
Type: Bug
Reporter: Mike Youngstrom
The header is being displayed twice when getting processed by AddResource.
The problem is that revision 210067 added insertPosition=0; before writing the rest of the page.
I've created a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-356) AddResource.writeWithFullHeader() writing old header twice
Posted by "Bruno Aranda (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-356?page=all ]
Bruno Aranda closed MYFACES-356:
--------------------------------
Fix Version: Nightly Build
Resolution: Fixed
I applied your patch to the current svn and everything works as expected now. Thanks Mike!
> AddResource.writeWithFullHeader() writing old header twice
> ----------------------------------------------------------
>
> Key: MYFACES-356
> URL: http://issues.apache.org/jira/browse/MYFACES-356
> Project: MyFaces
> Type: Bug
> Reporter: Mike Youngstrom
> Fix For: Nightly Build
>
> The header is being displayed twice when getting processed by AddResource.
> The problem is that revision 210067 added insertPosition=0; before writing the rest of the page.
> I've created a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-356) AddResource.writeWithFullHeader() writing old header twice
Posted by "Mike Youngstrom (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-356?page=comments#action_12316549 ]
Mike Youngstrom commented on MYFACES-356:
-----------------------------------------
Here is the patch.
Index: C:/Projects/PointBlank5/current/tomahawk/src/java/org/apache/myfaces/component/html/util/AddResource.java
===================================================================
--- C:/Projects/PointBlank5/current/tomahawk/src/java/org/apache/myfaces/component/html/util/AddResource.java (revision 224394)
+++ C:/Projects/PointBlank5/current/tomahawk/src/java/org/apache/myfaces/component/html/util/AddResource.java (working copy)
@@ -345,8 +345,6 @@
if(insertPosition>=0 && addHeaderTags)
writer.write("</head>");
- insertPosition=0;
-
writer.write( originalResponse.substring(insertPosition) );
}
> AddResource.writeWithFullHeader() writing old header twice
> ----------------------------------------------------------
>
> Key: MYFACES-356
> URL: http://issues.apache.org/jira/browse/MYFACES-356
> Project: MyFaces
> Type: Bug
> Reporter: Mike Youngstrom
>
> The header is being displayed twice when getting processed by AddResource.
> The problem is that revision 210067 added insertPosition=0; before writing the rest of the page.
> I've created a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira