You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 17:24:29 UTC

[GitHub] [spark] cloud-fan commented on pull request #34055: [SPARK-36721][SQL] Simplify boolean equalities if one side is literal

cloud-fan commented on pull request #34055:
URL: https://github.com/apache/spark/pull/34055#issuecomment-926010668


   > case a EqualTo TrueLiteral if a.dataType.isInstanceOf[BooleanType]
   
   This is not necessary. The analyzer guarantees that the inputs of binary comparisons are of the same type. We can just write `case a EqualTo TrueLiteral`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org