You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/13 12:00:32 UTC
[GitHub] [hudi] danny0405 opened a new pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
danny0405 opened a new pull request #3792:
URL: https://github.com/apache/hudi/pull/3792
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621",
"triggerID" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942892659
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08e11935b63637ef6d1a2fdd4fefc9bb92bb099f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621",
"triggerID" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634",
"triggerID" : "942892659",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#discussion_r728620696
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -189,6 +190,10 @@ public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
.enable(conf.getBoolean(FlinkOptions.METADATA_ENABLED))
.withMaxNumDeltaCommitsBeforeCompaction(conf.getInteger(FlinkOptions.METADATA_COMPACTION_DELTA_COMMITS))
.build())
+ .withPayloadConfig(HoodiePayloadConfig.newBuilder()
+ .withPayloadOrderingField(conf.getString(FlinkOptions.PRECOMBINE_FIELD))
+ .withPayloadEventTimeField(conf.getString(FlinkOptions.RECORD_KEY_FIELD))
Review comment:
Yes, we can add that when it is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621",
"triggerID" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634",
"triggerID" : "942892659",
"triggerType" : "MANUAL"
}, {
"hash" : "677cbef4d404808777dad21fc19e68b332b0ef0b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "677cbef4d404808777dad21fc19e68b332b0ef0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634)
* 677cbef4d404808777dad21fc19e68b332b0ef0b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on a change in pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#discussion_r728655818
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -189,6 +190,10 @@ public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
.enable(conf.getBoolean(FlinkOptions.METADATA_ENABLED))
.withMaxNumDeltaCommitsBeforeCompaction(conf.getInteger(FlinkOptions.METADATA_COMPACTION_DELTA_COMMITS))
.build())
+ .withPayloadConfig(HoodiePayloadConfig.newBuilder()
+ .withPayloadOrderingField(conf.getString(FlinkOptions.PRECOMBINE_FIELD))
+ .withPayloadEventTimeField(conf.getString(FlinkOptions.RECORD_KEY_FIELD))
Review comment:
hmm, not sure I understand when it is needed mean. Even users may use the same field for these two, but they have a completely different identity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#discussion_r728601033
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/BootstrapOperator.java
##########
@@ -129,6 +129,13 @@ public void initializeState(StateInitializationContext context) throws Exception
WriteOperationType.fromValue(conf.getString(FlinkOptions.OPERATION)),
HoodieTableType.valueOf(conf.getString(FlinkOptions.TABLE_TYPE)));
+ preLoadIndexRecords();
+ }
+
+ /**
+ * Load the index records before {@link #processElement}.
+ */
+ protected void preLoadIndexRecords() throws Exception {
Review comment:
Yes, just to fix the duplicate index loading of the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08e11935b63637ef6d1a2fdd4fefc9bb92bb099f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621",
"triggerID" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634",
"triggerID" : "942892659",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on a change in pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#discussion_r728585655
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/BootstrapOperator.java
##########
@@ -129,6 +129,13 @@ public void initializeState(StateInitializationContext context) throws Exception
WriteOperationType.fromValue(conf.getString(FlinkOptions.OPERATION)),
HoodieTableType.valueOf(conf.getString(FlinkOptions.TABLE_TYPE)));
+ preLoadIndexRecords();
+ }
+
+ /**
+ * Load the index records before {@link #processElement}.
+ */
+ protected void preLoadIndexRecords() throws Exception {
Review comment:
not related to this PR?
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -189,6 +190,10 @@ public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
.enable(conf.getBoolean(FlinkOptions.METADATA_ENABLED))
.withMaxNumDeltaCommitsBeforeCompaction(conf.getInteger(FlinkOptions.METADATA_COMPACTION_DELTA_COMMITS))
.build())
+ .withPayloadConfig(HoodiePayloadConfig.newBuilder()
+ .withPayloadOrderingField(conf.getString(FlinkOptions.PRECOMBINE_FIELD))
+ .withPayloadEventTimeField(conf.getString(FlinkOptions.RECORD_KEY_FIELD))
Review comment:
Eventtime key is actually different from record key. It should be a timestamp format. Should we add another option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08e11935b63637ef6d1a2fdd4fefc9bb92bb099f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #3792:
URL: https://github.com/apache/hudi/pull/3792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621",
"triggerID" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634",
"triggerID" : "942892659",
"triggerType" : "MANUAL"
}, {
"hash" : "677cbef4d404808777dad21fc19e68b332b0ef0b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2636",
"triggerID" : "677cbef4d404808777dad21fc19e68b332b0ef0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 677cbef4d404808777dad21fc19e68b332b0ef0b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2636)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#discussion_r728600818
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -189,6 +190,10 @@ public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
.enable(conf.getBoolean(FlinkOptions.METADATA_ENABLED))
.withMaxNumDeltaCommitsBeforeCompaction(conf.getInteger(FlinkOptions.METADATA_COMPACTION_DELTA_COMMITS))
.build())
+ .withPayloadConfig(HoodiePayloadConfig.newBuilder()
+ .withPayloadOrderingField(conf.getString(FlinkOptions.PRECOMBINE_FIELD))
+ .withPayloadEventTimeField(conf.getString(FlinkOptions.RECORD_KEY_FIELD))
Review comment:
Yes, you are with, as a default, we may use `FlinkOptions.PRECOMBINE_FIELD` as event time field.
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -189,6 +190,10 @@ public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
.enable(conf.getBoolean(FlinkOptions.METADATA_ENABLED))
.withMaxNumDeltaCommitsBeforeCompaction(conf.getInteger(FlinkOptions.METADATA_COMPACTION_DELTA_COMMITS))
.build())
+ .withPayloadConfig(HoodiePayloadConfig.newBuilder()
+ .withPayloadOrderingField(conf.getString(FlinkOptions.PRECOMBINE_FIELD))
+ .withPayloadEventTimeField(conf.getString(FlinkOptions.RECORD_KEY_FIELD))
Review comment:
Yes, you are right, as a default, we may use `FlinkOptions.PRECOMBINE_FIELD` as event time field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08e11935b63637ef6d1a2fdd4fefc9bb92bb099f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618)
* ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08e11935b63637ef6d1a2fdd4fefc9bb92bb099f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on a change in pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#discussion_r728607020
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -189,6 +190,10 @@ public static HoodieWriteConfig getHoodieClientConfig(Configuration conf) {
.enable(conf.getBoolean(FlinkOptions.METADATA_ENABLED))
.withMaxNumDeltaCommitsBeforeCompaction(conf.getInteger(FlinkOptions.METADATA_COMPACTION_DELTA_COMMITS))
.build())
+ .withPayloadConfig(HoodiePayloadConfig.newBuilder()
+ .withPayloadOrderingField(conf.getString(FlinkOptions.PRECOMBINE_FIELD))
+ .withPayloadEventTimeField(conf.getString(FlinkOptions.RECORD_KEY_FIELD))
Review comment:
then we need an EVENTTIME_FIELD right? we can set default as PRECOMBINE_FIELD, but I think in some cases users may set two separate fields for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3792: [HUDI-2551] Support DefaultHoodieRecordPayload for flink
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3792:
URL: https://github.com/apache/hudi/pull/3792#issuecomment-942232592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2618",
"triggerID" : "08e11935b63637ef6d1a2fdd4fefc9bb92bb099f",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621",
"triggerID" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"triggerType" : "PUSH"
}, {
"hash" : "ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634",
"triggerID" : "942892659",
"triggerType" : "MANUAL"
}, {
"hash" : "677cbef4d404808777dad21fc19e68b332b0ef0b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2636",
"triggerID" : "677cbef4d404808777dad21fc19e68b332b0ef0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba0dc0a6169de8b9a2c6ee9659ee9b7750d4d5b4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2621) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2634)
* 677cbef4d404808777dad21fc19e68b332b0ef0b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2636)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org