You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/05/20 14:32:53 UTC
[GitHub] [myfaces-tobago] henningn opened a new pull request #112: check getRootNode() usage
henningn opened a new pull request #112:
URL: https://github.com/apache/myfaces-tobago/pull/112
There are some unnecessary usage of getRootNode(). Now 'this' is used instead.
In the case of tobago-select-boolean-toggle we can just extends "SelectBooleanCheckbox".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces-tobago] JasminKroeger commented on pull request #112: check getRootNode() usage
Posted by GitBox <gi...@apache.org>.
JasminKroeger commented on pull request #112:
URL: https://github.com/apache/myfaces-tobago/pull/112#issuecomment-634643431
Looks good for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #112: check getRootNode() usage
Posted by GitBox <gi...@apache.org>.
henningn merged pull request #112:
URL: https://github.com/apache/myfaces-tobago/pull/112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org