You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Ken Giusti (JIRA)" <ji...@apache.org> on 2011/07/01 15:54:28 UTC
[jira] [Created] (QPID-3335) Remove duplicate and buggy type
conversion code from Management Agent.
Remove duplicate and buggy type conversion code from Management Agent.
----------------------------------------------------------------------
Key: QPID-3335
URL: https://issues.apache.org/jira/browse/QPID-3335
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.11
Reporter: Ken Giusti
Assignee: Ken Giusti
Fix For: 0.12
The broker's management agent exports a FieldTable to Variant Map translation API. This duplicates the translation code from the common library (Codecs.h), and the version in the management agent is stale and buggy. Remove the duplication and have the management agent use the common code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3335) Remove duplicate and buggy type
conversion code from Management Agent.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058556#comment-13058556 ]
jiraposter@reviews.apache.org commented on QPID-3335:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/988/
-----------------------------------------------------------
Review request for Gordon Sim, Kim van der Riet and Ted Ross.
Summary
-------
Removes some old code that duplicates type conversions that are available in the common library.
This addresses bug qpid-3335.
https://issues.apache.org/jira/browse/qpid-3335
Diffs
-----
/trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1141932
/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1141932
Diff: https://reviews.apache.org/r/988/diff
Testing
-------
unit.
Thanks,
Kenneth
> Remove duplicate and buggy type conversion code from Management Agent.
> ----------------------------------------------------------------------
>
> Key: QPID-3335
> URL: https://issues.apache.org/jira/browse/QPID-3335
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.11
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.12
>
>
> The broker's management agent exports a FieldTable to Variant Map translation API. This duplicates the translation code from the common library (Codecs.h), and the version in the management agent is stale and buggy. Remove the duplication and have the management agent use the common code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3335) Remove duplicate and buggy type
conversion code from Management Agent.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058560#comment-13058560 ]
jiraposter@reviews.apache.org commented on QPID-3335:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/988/#review952
-----------------------------------------------------------
Ship it!
- Gordon
On 2011-07-01 13:58:26, Kenneth Giusti wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/988/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-01 13:58:26)
bq.
bq.
bq. Review request for Gordon Sim, Kim van der Riet and Ted Ross.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removes some old code that duplicates type conversions that are available in the common library.
bq.
bq.
bq. This addresses bug qpid-3335.
bq. https://issues.apache.org/jira/browse/qpid-3335
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1141932
bq. /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1141932
bq.
bq. Diff: https://reviews.apache.org/r/988/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. unit.
bq.
bq.
bq. Thanks,
bq.
bq. Kenneth
bq.
bq.
> Remove duplicate and buggy type conversion code from Management Agent.
> ----------------------------------------------------------------------
>
> Key: QPID-3335
> URL: https://issues.apache.org/jira/browse/QPID-3335
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.11
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.12
>
>
> The broker's management agent exports a FieldTable to Variant Map translation API. This duplicates the translation code from the common library (Codecs.h), and the version in the management agent is stale and buggy. Remove the duplication and have the management agent use the common code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3335) Remove duplicate and buggy type
conversion code from Management Agent.
Posted by "Ken Giusti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ken Giusti resolved QPID-3335.
------------------------------
Resolution: Fixed
> Remove duplicate and buggy type conversion code from Management Agent.
> ----------------------------------------------------------------------
>
> Key: QPID-3335
> URL: https://issues.apache.org/jira/browse/QPID-3335
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.12
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.13
>
>
> The broker's management agent exports a FieldTable to Variant Map translation API. This duplicates the translation code from the common library (Codecs.h), and the version in the management agent is stale and buggy. Remove the duplication and have the management agent use the common code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3335) Remove duplicate and buggy type
conversion code from Management Agent.
Posted by "Ken Giusti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ken Giusti updated QPID-3335:
-----------------------------
Affects Version/s: (was: 0.11)
0.12
Fix Version/s: (was: 0.12)
0.13
> Remove duplicate and buggy type conversion code from Management Agent.
> ----------------------------------------------------------------------
>
> Key: QPID-3335
> URL: https://issues.apache.org/jira/browse/QPID-3335
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.12
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.13
>
>
> The broker's management agent exports a FieldTable to Variant Map translation API. This duplicates the translation code from the common library (Codecs.h), and the version in the management agent is stale and buggy. Remove the duplication and have the management agent use the common code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org