[shardingsphere] branch master updated: Fix sonar issues on Collection methods with O(n) performance should be used carefully (#25833)

[su...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 47d97d7c665 Fix sonar issues on Collection methods with O(n) performance should be used carefully (#25833)
47d97d7c665 is described below

commit 47d97d7c6654a7fda0625662b1677b1f417fe0d1
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Mon May 22 01:54:24 2023 +0800

    Fix sonar issues on Collection methods with O(n) performance should be used carefully (#25833)
---
 .../shardingsphere/sharding/rewrite/token/pojo/OrderByToken.java  | 8 ++++----
 .../data/pipeline/core/ingest/channel/memory/ManualBitSet.java    | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/OrderByToken.java b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/OrderByToken.java
index cb082880df2..0b769547333 100644
--- a/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/OrderByToken.java
+++ b/features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/OrderByToken.java
@@ -18,11 +18,11 @@
 package org.apache.shardingsphere.sharding.rewrite.token.pojo;
 
 import lombok.Getter;
-import org.apache.shardingsphere.sql.parser.sql.common.enums.OrderDirection;
 import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.Attachable;
 import org.apache.shardingsphere.infra.rewrite.sql.token.pojo.SQLToken;
+import org.apache.shardingsphere.sql.parser.sql.common.enums.OrderDirection;
 
-import java.util.LinkedList;
+import java.util.ArrayList;
 import java.util.List;
 
 /**
@@ -31,9 +31,9 @@ import java.util.List;
 @Getter
 public final class OrderByToken extends SQLToken implements Attachable {
     
-    private final List<String> columnLabels = new LinkedList<>();
+    private final List<String> columnLabels = new ArrayList<>();
     
-    private final List<OrderDirection> orderDirections = new LinkedList<>();
+    private final List<OrderDirection> orderDirections = new ArrayList<>();
     
     public OrderByToken(final int startIndex) {
         super(startIndex);
diff --git a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/channel/memory/ManualBitSet.java b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/channel/memory/ManualBitSet.java
index 7ee7134dcdd..5540d41f7a7 100644
--- a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/channel/memory/ManualBitSet.java
+++ b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/channel/memory/ManualBitSet.java
@@ -17,8 +17,8 @@
 
 package org.apache.shardingsphere.data.pipeline.core.ingest.channel.memory;
 
+import java.util.ArrayList;
 import java.util.BitSet;
-import java.util.LinkedList;
 import java.util.List;
 
 /**
@@ -28,7 +28,7 @@ public final class ManualBitSet {
     
     private static final int BIT_SET_SIZE = 1024;
     
-    private final List<BitSet> bitSets = new LinkedList<>();
+    private final List<BitSet> bitSets = new ArrayList<>();
     
     private long startIndex;