You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "anjo0511 (via GitHub)" <gi...@apache.org> on 2025/11/07 11:03:35 UTC
[PR] Authentication spinner #57981 [airflow]
anjo0511 opened a new pull request, #58037:
URL: https://github.com/apache/airflow/pull/58037
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #57981
related: #57981
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #58037: Spinner instad or error message when authentication flow waits
URL: https://github.com/apache/airflow/pull/58037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits #57981 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58037:
URL: https://github.com/apache/airflow/pull/58037#issuecomment-3542999721
Actually - can you please remove translations? We have been trying this in the past, and the flow where multiple translations are added in the PR are far less likely to "work" and "get more eyes" - that was part of the experiment I've done once. It seems that tit's way better to just add an English version - and let the translator do their translations in separate PRs - possibly "grouped" together with other translations.
Our tooling and AI help is making that flow way more efficient and natural.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits #57981 [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #58037:
URL: https://github.com/apache/airflow/pull/58037#issuecomment-3542942830
Agreed. Commiters: lets not merge this until we've had more eyes on the translations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits #57981 [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #58037:
URL: https://github.com/apache/airflow/pull/58037#discussion_r2516692648
##########
airflow-core/src/airflow/ui/src/pages/Error.tsx:
##########
@@ -16,19 +16,40 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { Box, VStack, Heading, Text, Button, Container, HStack, Code } from "@chakra-ui/react";
+import { Box, VStack, Heading, Text, Button, Container, HStack, Code, Spinner } from "@chakra-ui/react";
import { useTranslation } from "react-i18next";
-import { useNavigate, useRouteError, isRouteErrorResponse } from "react-router-dom";
+import { useNavigate, useRouteError, isRouteErrorResponse, useLocation } from "react-router-dom";
import { AirflowPin } from "src/assets/AirflowPin";
export const ErrorPage = () => {
const navigate = useNavigate();
const error = useRouteError();
+ const location = useLocation();
const { t: translate } = useTranslation();
let errorMessage = translate("error.defaultMessage");
let statusCode = "";
+
+ // Check if we're in the OAuth flow
+ const isInAuthFlow = location.pathname.includes('oauth') ||
+ location.pathname.includes('login') ||
+ (error && typeof error === 'object' && 'status' in error && error.status === 401);
+
+ // If we're in the auth flow, don't show the error page
+ if (isInAuthFlow) {
+ return (
+ <Box alignItems="center" display="flex" justifyContent="center" pt={36} px={4}>
+ <Container maxW="lg">
+ <VStack gap={8} textAlign="center">
+ <AirflowPin height="50px" width="50px" />
+ <Spinner size="xl" color="blue.500" />
+ <Text>Authenticating...</Text>
Review Comment:
Since we now support i18n, let’s add a key in airflow-core/src/airflow/ui/public/i18n/locales/en and use the translate function to display the string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits #57981 [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #58037:
URL: https://github.com/apache/airflow/pull/58037#issuecomment-3519884964
Could you help
1. Fix static check error
2. Attach a demo or screenshot for you change
3. Add some desciption in PR body for your change
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits #57981 [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #58037:
URL: https://github.com/apache/airflow/pull/58037#issuecomment-3542772469
My stamp more on implementation and Turkish translation. I think we might need more eyes on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits #57981 [airflow]
Posted by "anjo0511 (via GitHub)" <gi...@apache.org>.
anjo0511 commented on code in PR #58037:
URL: https://github.com/apache/airflow/pull/58037#discussion_r2549897211
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/common.json:
##########
@@ -91,7 +91,8 @@
"defaultMessage": "An unexpected error occurred",
"home": "Home",
"notFound": "Page Not Found",
- "title": "Error"
+ "title": "Error",
+ "authenticating": "Authenticating..."
Review Comment:
Then issue itself is not that the auth is not accepted but rather that the auth flow is delay or unsynced so that it displays an ugly ui bug whilst the auth flow is finishing. Hence I think "Authenticating..." is more accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Authentication spinner #57981 [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #58037:
URL: https://github.com/apache/airflow/pull/58037#issuecomment-3501899296
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Spinner instad or error message when authentication flow waits #57981 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #58037:
URL: https://github.com/apache/airflow/pull/58037#discussion_r2535629604
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/common.json:
##########
@@ -91,7 +91,8 @@
"defaultMessage": "An unexpected error occurred",
"home": "Home",
"notFound": "Page Not Found",
- "title": "Error"
+ "title": "Error",
+ "authenticating": "Authenticating..."
Review Comment:
Should we be a bit more verbose on this what it means? Like for example:
```suggestion
"title": "Authentication Error",
"authenticating": "Authentication no accepted, forwarding to login page..."
```
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/common.json:
##########
@@ -91,7 +91,8 @@
"defaultMessage": "An unexpected error occurred",
"home": "Home",
"notFound": "Page Not Found",
- "title": "Error"
+ "title": "Error",
+ "authenticating": "Authenticating..."
Review Comment:
Should we be a bit more verbose on this what it means? Like for example:
```suggestion
"title": "Authentication Error",
"authenticating": "Authentication not accepted, forwarding to login page..."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org