You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2019/10/16 07:18:00 UTC
[jira] [Commented] (HIVE-22351) Fix incorrect threaded ObjectStore
usage in TestObjectStore
[ https://issues.apache.org/jira/browse/HIVE-22351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952570#comment-16952570 ]
Hive QA commented on HIVE-22351:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 20s{color} | {color:blue} standalone-metastore/metastore-server in master has 170 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 35s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19013/dev-support/hive-personality.sh |
| git revision | master / fbabad1 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-19013/yetus/patch-asflicense-problems.txt |
| modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19013/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Fix incorrect threaded ObjectStore usage in TestObjectStore
> -----------------------------------------------------------
>
> Key: HIVE-22351
> URL: https://issues.apache.org/jira/browse/HIVE-22351
> Project: Hive
> Issue Type: Bug
> Affects Versions: 4.0.0
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22351.1.patch
>
>
> TestObjectStore#testConcurrentDropPartitions shares the same ObjectStore object across two threads doing concurrent drops. ObjectStore isn't thread safe. I've seen occasional deadlocks where one thread is rolling back and another is trying to commit with each thread waiting on the other (one is holding an object lock via a synchronized method and another is holding the ExecutionContextThreadedImpl lock). I think the intent is to test dropPartition behavior and ensure the backing DB receives a rollback or abort on conflicting drops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)