You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2023/06/01 17:11:41 UTC

[GitHub] [pulsar] nodece opened a new pull request, #20462: [fix][build] Improve the build of pulsar images

nodece opened a new pull request, #20462:
URL: https://github.com/apache/pulsar/pull/20462

   Fix #20420, #19544
   
   ### Motivation
   
   This PR addresses the following issues:
   
   1. Fix the errors that arise when using custom `docker.organization`, because we use hard-coded images in the Dockerfile, which always pulls images from the `apachepulsar` organization.
   2. When publishing the older versions of Pulsar, the `latest` tag will be broken: #19544.
   
   ### Modifications
   
   - Use the dynamic base image in the Dockerfile by the `ARG`.
   - Use the Maven property to set the latest image, default to `${project.version}` instead of `latest`, if you want to build the `latest` tag, please add `-Dpulsar.latest.image.tag=latest` to `mvn` command.
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [x] `doc-required` <!-- Your PR changes impact docs and you will update later -->
     - [ ] Update the release doc and script
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#issuecomment-1573124978

   > Thanks for the help. overall lgtm. It looks like the build process is covered by the current CI process. Is the image publishing process also tested in the current CI?
   
   Thank @jiazhai for your review, let me research the publishing process in the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#issuecomment-1573375254

   Waiting for #20435 into master, and then rebase this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #20462: [fix][build] Improve the build of pulsar images

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#issuecomment-1572462356

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiazhai commented on a diff in pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "jiazhai (via GitHub)" <gi...@apache.org>.
jiazhai commented on code in PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#discussion_r1213892802


##########
docker/pulsar/Dockerfile:
##########
@@ -44,7 +44,6 @@ RUN for SUBDIRECTORY in conf data download logs; do \
 
 # Trino writes logs to this directory (at least during tests), so we need to give the process permission
 # to create those log directories. This should be removed when Trino is removed.
-RUN chmod g+w /pulsar/trino

Review Comment:
   Why do we need this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#issuecomment-1617119766

   #20435 has resolved these issues and now closes this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiazhai commented on pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "jiazhai (via GitHub)" <gi...@apache.org>.
jiazhai commented on PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#issuecomment-1573120144

   Thanks for the help. overall lgtm. 
   It looks like the build process is covered by the current CI process. Is the image publishing process is also tested in the current CI. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#issuecomment-1617115025

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece closed pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece closed pull request #20462: [fix][build] Improve the build and publish of pulsar images
URL: https://github.com/apache/pulsar/pull/20462


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on a diff in pull request #20462: [fix][build] Improve the build and publish of pulsar images

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on code in PR #20462:
URL: https://github.com/apache/pulsar/pull/20462#discussion_r1213893576


##########
docker/pulsar/Dockerfile:
##########
@@ -44,7 +44,6 @@ RUN for SUBDIRECTORY in conf data download logs; do \
 
 # Trino writes logs to this directory (at least during tests), so we need to give the process permission
 # to create those log directories. This should be removed when Trino is removed.
-RUN chmod g+w /pulsar/trino

Review Comment:
   Reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org