You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/06/15 10:23:30 UTC
[GitHub] [dolphinscheduler] kyoty opened a new pull request #5633: update testcase after PR#5611
kyoty opened a new pull request #5633:
URL: https://github.com/apache/dolphinscheduler/pull/5633
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
in pr #5611
in table `t_ds_process_definition` we add a new unique key with `code`.
in `ProcessDefinitionMapperTest.java` , both `insertTwo` and `insertOne` methods use a same code would caue a duplicatete key error:
```java
Error: Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.082 s <<< FAILURE! - in org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapperTest
Error: testQueryDefinitionListByIdList(org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapperTest) Time elapsed: 0.007 s <<< ERROR!
org.springframework.dao.DuplicateKeyException:
### Error updating database. Cause: org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "code_unique"
Detail: Key (code)=(1) already exists.
### The error may exist in org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.java (best guess)
### The error may involve org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper.insert-Inline
### The error occurred while setting parameters
### SQL: INSERT INTO t_ds_process_definition ( code, timeout, project_code, update_time, user_id, version, create_time, tenant_id, name ) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ? )
### Cause: org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "code_unique"
Detail: Key (code)=(1) already exists.
; ERROR: duplicate key value violates unique constraint "code_unique"
Detail: Key (code)=(1) already exists.; nested exception is org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "code_unique"
Detail: Key (code)=(1) already exists.
at org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapperTest.insertTwo(ProcessDefinitionMapperTest.java:99)
at org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapperTest.testQueryDefinitionListByIdList(ProcessDefinitionMapperTest.java:312)
Caused by: org.postgresql.util.PSQLException:
ERROR: duplicate key value violates unique co
```
## Brief change log
update the existed UT
## Verify this pull request
Existed UTS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kyoty commented on pull request #5633: update testcase after PR#5611
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #5633:
URL: https://github.com/apache/dolphinscheduler/pull/5633#issuecomment-861381404
@wen-hemin please help to have a look at this pr, after the #5611, the testcase must be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #5633: update failed testcase after PR#5611
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #5633:
URL: https://github.com/apache/dolphinscheduler/pull/5633#issuecomment-861389148
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5633&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5633&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5633&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5633&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong merged pull request #5633: update failed testcase after PR#5611
Posted by GitBox <gi...@apache.org>.
zhuangchong merged pull request #5633:
URL: https://github.com/apache/dolphinscheduler/pull/5633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org