You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by Mike Rettig <mi...@gmail.com> on 2004/07/20 06:59:47 UTC
[PATCH] Swallowed Exception during rendering
I posted a bug to the user's forum a while ago. I dug into the source
and found the problem and came up with the following fix. An exception
was being swallowed, so I just changed the method signature to throw
the exception. This required a change to several calling methods but
nothing drastic.
Re: [PATCH] Swallowed Exception during rendering
Posted by Mike Rettig <mi...@gmail.com>.
Will,
Thanks for the suggestion. The EventCartridge appears to work for the
time being. I submitted the patch and some more details to bugzilla.
Thanks again,
Mike Rettig
On Tue, 20 Jul 2004 09:07:34 -0700, Will Glass-Husain <wg...@forio.com> wrote:
> Hi Mike,
>
> Thanks for working on this. I agree, it'd be nice if exceptions could be
> handled by Velocity's container.
>
> Am I wrong on this, or could you just install an event handler to throw the
> exception (instead of doing a patch).
>
> http://jakarta.apache.org/velocity/developer-guide.html#EventCartridge%20and%20Event%20Handlers
>
> If you think we still need this patch, I suggest you submit a bug report
> (which will keep a copy posted) with the patch.
> http://nagoya.apache.org/bugzilla
>
> A word of warning, this project is notorious for being slow in committing
> patches. But I think it's good to have them available.
>
> WILL
>
>
>
> ----- Original Message -----
> From: "Mike Rettig" <mi...@gmail.com>
> To: <ve...@jakarta.apache.org>
> Sent: Monday, July 19, 2004 9:59 PM
> Subject: [PATCH] Swallowed Exception during rendering
>
> > I posted a bug to the user's forum a while ago. I dug into the source
> > and found the problem and came up with the following fix. An exception
> > was being swallowed, so I just changed the method signature to throw
> > the exception. This required a change to several calling methods but
> > nothing drastic.
> >
>
>
> ----------------------------------------------------------------------------
> ----
>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
Re: [PATCH] Swallowed Exception during rendering
Posted by Will Glass-Husain <wg...@forio.com>.
Hi Mike,
Thanks for working on this. I agree, it'd be nice if exceptions could be
handled by Velocity's container.
Am I wrong on this, or could you just install an event handler to throw the
exception (instead of doing a patch).
http://jakarta.apache.org/velocity/developer-guide.html#EventCartridge%20and%20Event%20Handlers
If you think we still need this patch, I suggest you submit a bug report
(which will keep a copy posted) with the patch.
http://nagoya.apache.org/bugzilla
A word of warning, this project is notorious for being slow in committing
patches. But I think it's good to have them available.
WILL
----- Original Message -----
From: "Mike Rettig" <mi...@gmail.com>
To: <ve...@jakarta.apache.org>
Sent: Monday, July 19, 2004 9:59 PM
Subject: [PATCH] Swallowed Exception during rendering
> I posted a bug to the user's forum a while ago. I dug into the source
> and found the problem and came up with the following fix. An exception
> was being swallowed, so I just changed the method signature to throw
> the exception. This required a change to several calling methods but
> nothing drastic.
>
----------------------------------------------------------------------------
----
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org