You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/04 18:47:19 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3097: GOBBLIN-1257: Fix the handling of collection field types during ORC s…
sv2000 opened a new pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097
…chema up-conversion in compaction
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1257
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Currently, on schema change while copying map/list entries from the original schema into the evolved schema, all the entries in the collection point to the same reference. This is inadvertently caused by re-using the same WritableComparable object for all the values. In addition to fixing this issue, this PR:
1. Refactors/enhances existing unit tests, and
2. Introduces a new convenience class for local testing of the compaction job and provides a simple way of reproducing compaction issues locally. This class requires users to provide input data records in json format along with an input ORC schema. It generates the corresponding input ORC files and runs the compaction job against the generated input.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Added tests to OrcUtilsTest class.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3097: GOBBLIN-1257: Fix the handling of collection field types during ORC s…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3097: GOBBLIN-1257: Fix the handling of collection field types during ORC s…
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097#discussion_r485060376
##########
File path: gobblin-compaction/build.gradle
##########
@@ -31,6 +31,7 @@ dependencies {
// with hive-exec-core in older version(1.0.1), we need to shadow ord-mapreduce's transitive deps.
// and include direct orc-mapreduce library just as a compileOnly dependency
compileOnly externalDependency.orcMapreduce
+ compile externalDependency.orcTools
Review comment:
Should it be `testCompile`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on pull request #3097: GOBBLIN-1257: Fix the handling of collection field types during ORC s…
Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097#issuecomment-687323917
@autumnust Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3097: GOBBLIN-1257: Fix the handling of collection field types during ORC s…
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097#discussion_r485106012
##########
File path: gobblin-compaction/build.gradle
##########
@@ -31,6 +31,7 @@ dependencies {
// with hive-exec-core in older version(1.0.1), we need to shadow ord-mapreduce's transitive deps.
// and include direct orc-mapreduce library just as a compileOnly dependency
compileOnly externalDependency.orcMapreduce
+ compile externalDependency.orcTools
Review comment:
oh OK I didn't notice that ( utility class in src instead of test).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3097: GOBBLIN-1257: Fix the handling of collection field types during ORC s…
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097#discussion_r485086038
##########
File path: gobblin-compaction/build.gradle
##########
@@ -31,6 +31,7 @@ dependencies {
// with hive-exec-core in older version(1.0.1), we need to shadow ord-mapreduce's transitive deps.
// and include direct orc-mapreduce library just as a compileOnly dependency
compileOnly externalDependency.orcMapreduce
+ compile externalDependency.orcTools
Review comment:
Since the utility class that allows users to run compaction locally is not a unit test, I had it located in the src/main of gobblin-compaction module. Also, this dependency will be needed at runtime, hence I chose "compile".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org