You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jim R. Wilson (JIRA)" <ji...@apache.org> on 2008/04/30 18:43:57 UTC

[jira] Created: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

HRegionServer::getThisIP() checks hadoop config var for dns interface name
--------------------------------------------------------------------------

                 Key: HBASE-608
                 URL: https://issues.apache.org/jira/browse/HBASE-608
             Project: Hadoop HBase
          Issue Type: Bug
          Components: regionserver
    Affects Versions: 0.1.1, 0.1.2
         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
            Reporter: Jim R. Wilson
             Fix For: 0.1.2


The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "Jim R. Wilson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593372#action_12593372 ] 

jimbojw edited comment on HBASE-608 at 4/30/08 9:46 AM:
--------------------------------------------------------------

Index: conf/hbase-default.xml
===================================================================
--- conf/hbase-default.xml	(revision 652397)
+++ conf/hbase-default.xml	(working copy)
@@ -57,6 +57,15 @@
     </description>
   </property>
   <property>
+    <name>hbase.regionserver.dns.interface</name>
+    <value>default</value>
+    <description>Name of the network interface which a regionserver
+    should use to determine it's "real" IP address.  This lookup
+    prevents strings like "localhost" and "127.0.0.1" from being
+    reported back to the master.
+    </description>
+  </property>
+  <property>
     <name>hbase.regionserver.info.port</name>
     <value>60030</value>
     <description>The port for the hbase regionserver web UI
Index: src/java/org/apache/hadoop/hbase/HRegionServer.java
===================================================================
--- src/java/org/apache/hadoop/hbase/HRegionServer.java	(revision 652397)
+++ src/java/org/apache/hadoop/hbase/HRegionServer.java	(working copy)
@@ -1042,7 +1042,7 @@
    * @return This servers' IP.
    */
   private String getThisIP() throws UnknownHostException {
-    return DNS.getDefaultIP(conf.get("dfs.datanode.dns.interface","default"));
+    return DNS.getDefaultIP(conf.get("hbase.regionserver.dns.interface","default"));
   }
 
   /**

      was (Author: jimbojw):
    Alters HRegionServer::getThisIP() to check for "hbase.regionserver.dns.interface", and adds that property to conf/hbase-default.xml
  
> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.2, 0.1.1
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.1.2
>
>         Attachments: hbase-regionserver-dns-interface.diff
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "Jim R. Wilson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593622#action_12593622 ] 

Jim R. Wilson commented on HBASE-608:
-------------------------------------

Cool cool - thanks stack!

> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.2, 0.1.1
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.2.0, 0.1.2
>
>         Attachments: hbase-regionserver-dns-interface.diff
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-608:
------------------------

       Resolution: Fixed
    Fix Version/s: 0.2.0
           Status: Resolved  (was: Patch Available)

Applied to patch and trunk.  Thanks for the patch Jim.

> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.2, 0.1.1
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.2.0, 0.1.2
>
>         Attachments: hbase-regionserver-dns-interface.diff
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593376#action_12593376 ] 

stack commented on HBASE-608:
-----------------------------

+1 on patch.  I'll apply it to branch and trunk

> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.2, 0.1.1
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.1.2
>
>         Attachments: hbase-regionserver-dns-interface.diff
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "Jim R. Wilson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim R. Wilson updated HBASE-608:
--------------------------------

    Attachment: hbase-regionserver-dns-interface.diff

Alters HRegionServer::getThisIP() to check "hbase.regionserver.dns.interface" instead of "dfs.datanode.dns.interface", and adds new property to conf/hbase-default.xml

> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.2, 0.1.1
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.1.2
>
>         Attachments: hbase-regionserver-dns-interface.diff
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593384#action_12593384 ] 

stack commented on HBASE-608:
-----------------------------

Can't commit at moment 'cos svn is down.  Will do when it comes back online.

> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.2, 0.1.1
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.1.2
>
>         Attachments: hbase-regionserver-dns-interface.diff
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "Jim R. Wilson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim R. Wilson updated HBASE-608:
--------------------------------

    Comment: was deleted

> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.2, 0.1.1
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.1.2
>
>         Attachments: hbase-regionserver-dns-interface.diff
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-608) HRegionServer::getThisIP() checks hadoop config var for dns interface name

Posted by "Jim R. Wilson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim R. Wilson updated HBASE-608:
--------------------------------

    Status: Patch Available  (was: Open)

Alters HRegionServer::getThisIP() to check for "hbase.regionserver.dns.interface", and adds that property to conf/hbase-default.xml

> HRegionServer::getThisIP() checks hadoop config var for dns interface name
> --------------------------------------------------------------------------
>
>                 Key: HBASE-608
>                 URL: https://issues.apache.org/jira/browse/HBASE-608
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.1, 0.1.2
>         Environment: Red Hat Enterprise Linux, Java 1.5, Hadoop 0.16
>            Reporter: Jim R. Wilson
>             Fix For: 0.1.2
>
>
> The getThisIP() method of the HRegionServer class checks for the hadoop config var "dfs.datanode.dns.interface" rather than an hbase-specific configuration property.  I propose a new config var called "hbase.regionserver.dns.interface" to check instead.  Will attach patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.