You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/23 00:24:34 UTC
[GitHub] [airflow] mik-laj opened a new pull request #21040: Add image labels required by ArtifactHub
mik-laj opened a new pull request #21040:
URL: https://github.com/apache/airflow/pull/21040
To better promote our image, I would like to publish it on ArtifactHub, but it requires additional labels.
Here is doc:
https://artifacthub.io/docs/topics/repositories/#container-images-repositories
I'm just wondering about the difference between `io.artifacthub.package.license` and `org.opencontainers.image.licenses`, but I've already contacted the developer to clarify it. For now, we can keep both labels until we know the difference.
Part-of: https://github.com/apache/airflow/issues/11740
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019388914
Why do we need to set-up the labels in the image ? Isn't that enough to add the image meta-data to ArtifactHub? What's the process of publishing the image ? Do we have to publish it every time to artifactHub when we release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019391049
> Why do we need to set-up the labels in the image? Isn't that enough to add the image meta-data to ArtifactHub?
After adding an image to ArtifactHub, ArtifactHub regularly scans the images and updates its database based on metadata. Within ArtifactHub, you can only specify the register, tags and the nature of the tag (mutable/immutable).
> What's the process of publishing the image ? Do we have to publish it every time to artifactHub when we release?
Now I have checked it and unfortunately, it has to be done manually every time a new tag is published, but any tag update should be detected automatically. Hopefully, Artifact Hub will also add the ability to create tags automatically based on the registry content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019423007
I wonder if it might be better to add these labels with `docker build --label`. They only make sense if we want to publish this image on ArtifactHub, but most people probably won't, so they will contain incorrect/useless information. This further allows us to add other labels that are supported by ArtifactHub without creating arguments to customize. @potiuk WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019388796
> BTW. This is completely different issue
Merging this PR brings us a little closer to achieving the goals outlined in this issue because this PR adds the `README.md `file which is needed to create a new repository. It's not a complete solution to the mentioned issues, but it does a part of the work required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019392103
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019423007
I wonder if it might be better to add these labels with `docker build --label`. They only make sense if we want to publish this image on ArtifactHub, but most people probably won't, so they will contain incorrect / useless information. @potiuk WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019388162
> I think publishing airflow image in multiple registries might be disastrous
This does not publish the image to new registers. ArtifactHub is just a catalog of images that can come from different registries.
> We have another discussion now about potentially putting our image to Apache Registry or Ghcr.io.
Adding our image will not make it difficult, quite the contrary. ArtifactHub allows you to specify alternative locations of image, which will only improve image discovery.
For example:
```
https://artifacthub.io/packages/container/ah/ah
```
was published in two locations:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019391963
> Now I have checked it and unfortunately, it has to be done manually every time a new tag is published, but any tag update should be detected automatically. Hopefully, Artifact Hub will also add the ability to create tags automatically based on the registry content.
I think we can just publish mutable "latest" tags this way ("latest", "latest-python3.6" etc.). That will work fine with our approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019391963
> Now I have checked it and unfortunately, it has to be done manually every time a new tag is published, but any tag update should be detected automatically. Hopefully, Artifact Hub will also add the ability to create tags automatically based on the registry content.
I think we can just publish "latest" tags this way. That will work fine with our approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019388162
> I think publishing airflow image in multiple registries might be disastrous
This does not publish the image to new registers. ArtifactHub is just a catalog of images that can come from different registries.
> We have another discussion now about potentially putting our image to Apache Registry or Ghcr.io.
Adding our image will not make it difficult, quite the contrary. ArtifactHub allows you to specify alternative locations, which will only improve image discovery.
For example:
```
https://artifacthub.io/packages/container/ah/ah
```
was published in two locations:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019386129
> Part-of: #11740
BTW. This is completely different issue . The #11740 is about having a smaller source repo which our users could check out and build their own images without checking out the whole repository. It's only purpose is to serve the "Customizing the image" route - where Dockerfile + related files are used with custom parameters to build optimized image - it has nothing to do with the "binary" image we are publishing in DockerHub:
https://airflow.apache.org/docs/docker-stack/build.html#customizing-the-image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019388162
> I think publishing airflow image in multiple registries might be disastrous
This does not publish the image to new registers. ArtifactHub is just a catalog of images that can come from different registries.
> We have another discussion now about potentially putting our image to Apache Registry or Ghcr.io.
Adding our image will not make it difficult, quite the contrary. ArtifactHub allows us to specify alternative locations of image, which will only improve image discovery.
For example:
```
https://artifacthub.io/packages/container/ah/ah
```
was published in two locations:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019423007
I wonder if it might be better to add these labels with `docker build --label` i.e. as a docker command argument instead of Dockerfile instruction. These labels only make sense if we want to publish this image on ArtifactHub, but most people probably won't, so they will contain incorrect/useless information. This further allows us to add other labels that are supported by ArtifactHub without creating arguments to customize. @potiuk WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019392259
BTW. We will have also "slim" image https://github.com/apache/airflow/issues/20849 - but those will be "container" tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21040:
URL: https://github.com/apache/airflow/pull/21040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019389856
Yeah. I looked at the docs and it does make sense to add it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21040: Add image labels required by ArtifactHub
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21040:
URL: https://github.com/apache/airflow/pull/21040#issuecomment-1019459589
Might be a good idea. This could be the same with thr open container labels. It was not possible before when we utilized ghcr.iio and build image for caching but with buildx and multi- segmented caching it is entirely possible to move all labels out. But i would do it as part of our python breeze rewrite project to not complicate the rewrite effort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org