You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Bikas Saha (JIRA)" <ji...@apache.org> on 2014/06/10 05:08:01 UTC

[jira] [Updated] (TEZ-1131) Simplify EdgeManager.routeDataMovementEventToDestination()

     [ https://issues.apache.org/jira/browse/TEZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bikas Saha updated TEZ-1131:
----------------------------

    Attachment: TEZ-1131.1.patch

Makes the above mentioned changes
1) adds sourceOutputIndex to API
2) Changes Map<InputIndex, List<TaskIndex>> to Map<TaskIndex, List<InputIndex>> which is more straight-forward to understand.
3) Removes API parameters like numDestinationTasks etc which were a relic of the past when context was not available. Now that info is available via context.
4) Removes unused sourceIndex in InputFailedEvent.

[~hitesh] Please review

> Simplify EdgeManager.routeDataMovementEventToDestination()
> ----------------------------------------------------------
>
>                 Key: TEZ-1131
>                 URL: https://issues.apache.org/jira/browse/TEZ-1131
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>         Attachments: TEZ-1131.1.patch
>
>
> 2 pieces of feedback from [~daijy] 
> 1) Its not clear the event.sourceIndex needs to be accessed. Solution - Make it part of the method parameters
> 2) the Map<InputIndex, List<TaskIndex>> is convoluted. Solution - Replace with Map<TaskIndex, InputIndex>. Amazing why we did not do this in the first place.



--
This message was sent by Atlassian JIRA
(v6.2#6252)