You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2019/07/01 08:03:19 UTC

[servicecomb-java-chassis] branch weak-contract-type updated: [SCB-1338][WIP][WEAK] tiny optimize for collect primitive default value

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch weak-contract-type
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/weak-contract-type by this push:
     new bb0527e  [SCB-1338][WIP][WEAK] tiny optimize for collect primitive default value
bb0527e is described below

commit bb0527e377b20e70a1f0464478a40ad6a29f51c3
Author: wujimin <wu...@huawei.com>
AuthorDate: Sun Jun 30 21:44:45 2019 +0800

    [SCB-1338][WIP][WEAK] tiny optimize for collect primitive default value
---
 .../servicecomb/swagger/generator/jaxrs/JaxrsOperationGenerator.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/swagger/swagger-generator/generator-jaxrs/src/main/java/org/apache/servicecomb/swagger/generator/jaxrs/JaxrsOperationGenerator.java b/swagger/swagger-generator/generator-jaxrs/src/main/java/org/apache/servicecomb/swagger/generator/jaxrs/JaxrsOperationGenerator.java
index d4f6ca3..999d023 100644
--- a/swagger/swagger-generator/generator-jaxrs/src/main/java/org/apache/servicecomb/swagger/generator/jaxrs/JaxrsOperationGenerator.java
+++ b/swagger/swagger-generator/generator-jaxrs/src/main/java/org/apache/servicecomb/swagger/generator/jaxrs/JaxrsOperationGenerator.java
@@ -30,6 +30,8 @@ import org.apache.servicecomb.swagger.generator.core.AbstractSwaggerGenerator;
 import org.apache.servicecomb.swagger.generator.core.model.HttpParameterType;
 import org.apache.servicecomb.swagger.generator.rest.RestOperationGenerator;
 
+import com.google.common.base.Defaults;
+
 import io.swagger.models.Swagger;
 import io.swagger.models.parameters.AbstractSerializableParameter;
 
@@ -67,7 +69,7 @@ public class JaxrsOperationGenerator extends RestOperationGenerator {
 
     AbstractSerializableParameter<?> serializableParameter = (AbstractSerializableParameter<?>) parameter;
     if (serializableParameter.getDefault() == null && !parameter.getRequired()) {
-      serializableParameter.setDefaultValue(type.getTypeName().equals("boolean") ? "false" : "0");
+      serializableParameter.setDefaultValue(String.valueOf(Defaults.defaultValue((Class<?>) type)));
     }
   }
 }