You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 07:30:01 UTC
[GitHub] [spark] Yikun opened a new pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler
Yikun opened a new pull request #34239:
URL: https://github.com/apache/spark/pull/34239
### What changes were proposed in this pull request?
This patch adds the support driver for selecting scheduler through schedulerName.
### Why are the changes needed?
We have added the scheduler specified ability in executor side, https://github.com/apache/spark/pull/26088. And in some scenarios, users want to specify the driver scheduler to make sure driverPod can be scheduled separately.
Part of [SPARK-36059](https://issues.apache.org/jira/browse/SPARK-36059) .
### Does this PR introduce _any_ user-facing change?
Yes, add `spark.kubernetes.driver.scheduler.name` conf
### How was this patch tested?
- UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940583453
**[Test build #144112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144112/testReport)** for PR 34239 at commit [`9149ba3`](https://github.com/apache/spark/commit/9149ba38a612583c0c3d1226ba4547b480aa5532).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726691579
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -228,6 +228,13 @@ private[spark] object Config extends Logging {
.stringConf
.createOptional
+ val KUBERNETES_DRIVER_SCHEDULER_NAME =
+ ConfigBuilder("spark.kubernetes.driver.scheduler.name")
+ .doc("Specify the scheduler name for each driver pod")
Review comment:
Done, I change it to `Specify the scheduler name for driver pod`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939803340
**[Test build #144071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144071/testReport)** for PR 34239 at commit [`aad1f34`](https://github.com/apache/spark/commit/aad1f34a7de54a3011cfb091032a8520537f5e6b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940621758
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48589/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939768676
cc @holdenk @dongjoon-hyun , maybe @LuciferYang @yaooqinn also have interest on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939879661
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48549/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940660393
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726708161
##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
##########
@@ -198,4 +198,14 @@ class KubernetesConfSuite extends SparkFunSuite {
assert(driverConf.nodeSelector === CUSTOM_NODE_SELECTOR)
assert(driverConf.driverNodeSelector === CUSTOM_DRIVER_NODE_SELECTOR)
}
+
+ test("SPARK-36059: Set driver.scheduler and excutor.scheduler") {
Review comment:
can we add a test when these configurations are not specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940578125
**[Test build #144112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144112/testReport)** for PR 34239 at commit [`9149ba3`](https://github.com/apache/spark/commit/9149ba38a612583c0c3d1226ba4547b480aa5532).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940621780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48589/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940578125
**[Test build #144112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144112/testReport)** for PR 34239 at commit [`9149ba3`](https://github.com/apache/spark/commit/9149ba38a612583c0c3d1226ba4547b480aa5532).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34239: [SPARK-36059][K8S] Support `spark.kubernetes.driver.scheduler.name`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-943051129
Thank you, @Yikun and all.
Merged to master for Apache Spark 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940647151
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144119/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939788830
**[Test build #144071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144071/testReport)** for PR 34239 at commit [`aad1f34`](https://github.com/apache/spark/commit/aad1f34a7de54a3011cfb091032a8520537f5e6b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940647151
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144119/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939832598
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144071/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940680363
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940592400
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144112/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939879661
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48549/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r725862371
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1306,6 +1306,22 @@ See the [configuration page](configuration.html) for information on Spark config
</td>
<td>3.3.0</td>
</tr>
+<tr>
+ <td><code>spark.kubernetes.executor.scheduler.name<code></td>
+ <td>(none)</td>
+ <td>
+ Specify the scheduler name for each executor pod.
+ </td>
+ <td>3.0.0</td>
Review comment:
3.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940598055
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48589/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940436800
Thank you for pinging me, @Yikun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726739698
##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
##########
@@ -198,4 +198,14 @@ class KubernetesConfSuite extends SparkFunSuite {
assert(driverConf.nodeSelector === CUSTOM_NODE_SELECTOR)
assert(driverConf.driverNodeSelector === CUSTOM_DRIVER_NODE_SELECTOR)
}
+
+ test("SPARK-36059: Set driver.scheduler and excutor.scheduler") {
Review comment:
Thanks for suggestion and looks like I need address the empty conf case. If we didn't set scheduler name, the schedulerName should be "".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940646959
**[Test build #144119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144119/testReport)** for PR 34239 at commit [`3dfd2ce`](https://github.com/apache/spark/commit/3dfd2ce269c69208a1ea5b867fecf6a830a190ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34239: [SPARK-36059][K8S] Support `spark.kubernetes.driver.scheduler.name`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34239:
URL: https://github.com/apache/spark/pull/34239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940639957
**[Test build #144119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144119/testReport)** for PR 34239 at commit [`3dfd2ce`](https://github.com/apache/spark/commit/3dfd2ce269c69208a1ea5b867fecf6a830a190ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940693871
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726568608
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
##########
@@ -41,6 +41,7 @@ private[spark] abstract class KubernetesConf(val sparkConf: SparkConf) {
def secretEnvNamesToKeyRefs: Map[String, String]
def secretNamesToMountPaths: Map[String, String]
def volumes: Seq[KubernetesVolumeSpec]
+ def schedulerName: String
Review comment:
Thanks. This is a nice way to put this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726568089
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -228,6 +228,13 @@ private[spark] object Config extends Logging {
.stringConf
.createOptional
+ val KUBERNETES_DRIVER_SCHEDULER_NAME =
+ ConfigBuilder("spark.kubernetes.driver.scheduler.name")
+ .doc("Specify the scheduler name for each driver pod")
Review comment:
It seems to be copied from line 226. Shall we revise `each driver pod` a little because there is only one driver pod?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939868209
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48549/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939832598
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144071/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939821726
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48549/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34239: [SPARK-36059][KUBERNETES] Add the ability to specify a scheduler
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-939788830
**[Test build #144071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144071/testReport)** for PR 34239 at commit [`aad1f34`](https://github.com/apache/spark/commit/aad1f34a7de54a3011cfb091032a8520537f5e6b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726739698
##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
##########
@@ -198,4 +198,14 @@ class KubernetesConfSuite extends SparkFunSuite {
assert(driverConf.nodeSelector === CUSTOM_NODE_SELECTOR)
assert(driverConf.driverNodeSelector === CUSTOM_DRIVER_NODE_SELECTOR)
}
+
+ test("SPARK-36059: Set driver.scheduler and excutor.scheduler") {
Review comment:
Thanks for suggestion and looks like I need address the emtpy conf case. If we didn't set scheduler name, the schedulerName should be "".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940639957
**[Test build #144119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144119/testReport)** for PR 34239 at commit [`3dfd2ce`](https://github.com/apache/spark/commit/3dfd2ce269c69208a1ea5b867fecf6a830a190ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940592400
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144112/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940621780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48589/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #34239:
URL: https://github.com/apache/spark/pull/34239#discussion_r726745110
##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
##########
@@ -198,4 +198,14 @@ class KubernetesConfSuite extends SparkFunSuite {
assert(driverConf.nodeSelector === CUSTOM_NODE_SELECTOR)
assert(driverConf.driverNodeSelector === CUSTOM_DRIVER_NODE_SELECTOR)
}
+
+ test("SPARK-36059: Set driver.scheduler and excutor.scheduler") {
Review comment:
thanks for the check @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34239: [SPARK-36059][K8S] Add the ability to specify a scheduler (driver side)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34239:
URL: https://github.com/apache/spark/pull/34239#issuecomment-940693871
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48596/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org