You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Jan Matèrne <ja...@materne.de> on 2017/05/17 07:40:32 UTC
Ivy - Buildjobs/PreCommit
I read the wiki page https://wiki.apache.org/general/PreCommitBuilds, the
Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and had a look
at some other PreCommit-jobs.
For me this works like that:
1. The PreCommit-Admin job checks regularly on for new patches in Jira.
2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and file-ID as
argument.
3. The job does the rest.
That means the job itself has to apply the patchfile - and of course run the
build.
On the other hand I found a blog post from infra
https://blogs.apache.org/infra/entry/github_pull_request_builds_now and set
up an according job
https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
This job uses the Github integration by Cloudbees Enterprise plugin.
So next step for test would be a new/updated PR ...
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Ivy - Buildjobs/PreCommit
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
I'll try setting up the PreCommit-Job as Matrix job with Linux/Window.
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by Nicolas Lalevée <ni...@hibnet.org>.
> Le 20 mai 2017 à 11:18, Nicolas Lalevée <ni...@hibnet.org> a écrit :
>
>
>> Le 20 mai 2017 à 04:45, J Pai <ja...@gmail.com> a écrit :
>>
>> This pre-commit job is now almost functional. It gets triggered whenever there’s a PR and runs the build and tests and reports back if there are any failures.
>>
>> However, the only thing that’s pending or seems to be an issue is it sometimes doesn’t report back with the status. In these 2 PRs https://github.com/apache/ant-ivy/pull/19 https://github.com/apache/ant-ivy/pull/20 the status was never reported back to github (one of the jobs succeeded and the other failed, so there isn’t a clear hint of when this happens).
>
> I have seen that. In the config I didn’t see any obvious option that fix that.
Seems to be working now. At least for that PR:
https://github.com/apache/ant-ivy/pull/26 <https://github.com/apache/ant-ivy/pull/26>
That’s awesome!
Nicolas
Re: Ivy - Buildjobs/PreCommit
Posted by Nicolas Lalevée <ni...@hibnet.org>.
> Le 24 mai 2017 à 13:13, Jan Matèrne (jhm) <ap...@materne.de> a écrit :
>
> Not sure about this expertise because my sources were old, but I think the github-plugin does not support matrix jobs.
> https://github.com/KostyaSha/github-integration-plugin/issues/53
>
> Maybe a newer plugin version would do, but I could not see the version stamp.
> I'll ask on builds@a.o for help.
>
> For the meanwhile I deactivated the matrix-PR-job and reactivated the 'old' plain-PR-job.
>
> If we can't get matrix support we should be to create our own 'matrix' by copying that job and sticking to certain configurations.
> While a matrix would scale this approach won't. So we should define only 2-4 most interesting configs like
> - Java7@Unix
> - Java7@Windows
> - Java8@Unix
I think we can even stick to only two configs. Testing on two different OS is the real pain and I don’t remember having big issues with jvm versions.
We could even for now stick to Windows if most committers are on Unix machines. At least I am.
And in the end we still have the more exhaustive matrix build which runs after the commit being merged into the asf repo.
Nicolas
>
>
> Jan
>
>> -----Ursprüngliche Nachricht-----
>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>> Gesendet: Montag, 22. Mai 2017 14:45
>> An: Ant Developers List
>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>
>> It looks like there might be some issue with the matrix job(s)
>> https://builds.apache.org/job/Ivy-GithubPR-Matrix/2/console
>>
>> From what I understand of that log, it seems like the parent matrix job
>> (the one above) is correctly checking out the commit from the submitted
>> PR:
>>
>>> Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e
>> (master) > git config core.sparsecheckout # timeout=10 > git checkout
>> -f c1765c71ba4394597409de790bf4529ff97e866e
>>> git rev-parse origin/master^{commit} # timeout=10 > git rev-list
>> 239bc0b04a95d6c0f82e59c513de36d68c033c6a # timeout=10
>>
>> However, it then hands off the job execution to individual
>> Windows/Linux jobs and those jobs https://builds.apache.org/job/Ivy-
>> GithubPR-Matrix/jdk=JDK%201.7%20(latest),os=ubuntu/2/console don’t seem
>> to be able to checkout the commit(s) from the PR and fail with error
>> like:
>>
>>> Fetching upstream changes from https://github.com/apache/ant-ivy/
>>
>>> git --version # timeout=10
>>> git fetch --tags --progress
>> https://github.com/apache/ant-ivy/
>> +refs/heads/*:refs/remotes/origin/*
>> Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e (master)
>>> git config core.sparsecheckout # timeout=10 > git checkout -f
>> c1765c71ba4394597409de790bf4529ff97e866e
>> FATAL: Could not checkout c1765c71ba4394597409de790bf4529ff97e866e
>>
>> hudson.plugins.git.GitException
>> : Command "git checkout -f c1765c71ba4394597409de790bf4529ff97e866e"
>> returned status code 128:
>> stdout:
>> stderr: fatal: reference is not a tree:
>> c1765c71ba4394597409de790bf4529ff97e866e
>>
>> at
>> org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPI
>> Impl.java:1866)
>>
>>
>> -Jaikiran
>>
>> On 22-May-2017, at 12:25 PM, Jan Matèrne (jhm) <ap...@materne.de>
>> wrote:
>>
>>>> On a related note, while we are at this - does Apache infra allow
>> the
>>> jobs to be run against Windows OS Jenkins agents as well? There are a
>>> few issues specifically reported against Windows OS and having the
>> job
>>> run against linux and Windows OS should give a decent coverage for
>> the
>>> upstream code.
>>>
>>> In Jenkins there is the concept of « Matrix » job.
>>> Here is the ones for Ant:
>>> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
>>> Windows/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-
>>> Matrix-1.9.x-Windows/>
>>> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
>>> Linux/
>>> <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-
>>> 1.9.x-Linux/>
>>> AFAIR, it used to be able to do on several different OS. I don’t know
>>> why they are split.
>>>
>>> And I don’t know if it is possible to do it while pulling a PR from
>>> github.
>>
>>
>> New buildjob "Ivy-GithubPR-Matrix". I deactivated the old (so we could
>> easily switch back).
>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR-Matrix/
>> Basically a copy of the old job:
>> * discard old build jobs (keep 10)
>> * git merge support: fail the build if push fails
>> * github project: git://github.com/apache/ant-ivy.git
>> * git
>> -- repository: git://github.com/apache/ant-ivy.git
>> -- branches: */master (= default)
>> -- clean before checkout
>> -- recursively update submodules
>> -- build commits submitted for validated merge (= PR support)
>> * start build: build pull request to the repository (= PR support)
>> * configuration matrix
>> -- JDK: JDK 1.7 (latest), JDK 1.8 (latest), JDK 9 b156 with jigsaw
>> -- os: label expression = ["ubuntu", "Windows"]
>> * abort the build if it's stuck: absolute 20 minutes
>> * Lock: Ant
>> * build
>> -- ant(standard): clean coverage-report
>> * publish junit: build/test-report/**
>>
>>
>> Jan
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Ivy - Buildjobs/PreCommit
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
Not sure about this expertise because my sources were old, but I think the github-plugin does not support matrix jobs.
https://github.com/KostyaSha/github-integration-plugin/issues/53
Maybe a newer plugin version would do, but I could not see the version stamp.
I'll ask on builds@a.o for help.
For the meanwhile I deactivated the matrix-PR-job and reactivated the 'old' plain-PR-job.
If we can't get matrix support we should be to create our own 'matrix' by copying that job and sticking to certain configurations.
While a matrix would scale this approach won't. So we should define only 2-4 most interesting configs like
- Java7@Unix
- Java7@Windows
- Java8@Unix
Jan
> -----Ursprüngliche Nachricht-----
> Von: J Pai [mailto:jai.forums2013@gmail.com]
> Gesendet: Montag, 22. Mai 2017 14:45
> An: Ant Developers List
> Betreff: Re: Ivy - Buildjobs/PreCommit
>
> It looks like there might be some issue with the matrix job(s)
> https://builds.apache.org/job/Ivy-GithubPR-Matrix/2/console
>
> From what I understand of that log, it seems like the parent matrix job
> (the one above) is correctly checking out the commit from the submitted
> PR:
>
> > Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e
> (master) > git config core.sparsecheckout # timeout=10 > git checkout
> -f c1765c71ba4394597409de790bf4529ff97e866e
> > git rev-parse origin/master^{commit} # timeout=10 > git rev-list
> 239bc0b04a95d6c0f82e59c513de36d68c033c6a # timeout=10
>
> However, it then hands off the job execution to individual
> Windows/Linux jobs and those jobs https://builds.apache.org/job/Ivy-
> GithubPR-Matrix/jdk=JDK%201.7%20(latest),os=ubuntu/2/console don’t seem
> to be able to checkout the commit(s) from the PR and fail with error
> like:
>
> > Fetching upstream changes from https://github.com/apache/ant-ivy/
>
> > git --version # timeout=10
> > git fetch --tags --progress
> https://github.com/apache/ant-ivy/
> +refs/heads/*:refs/remotes/origin/*
> Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e (master)
> > git config core.sparsecheckout # timeout=10 > git checkout -f
> c1765c71ba4394597409de790bf4529ff97e866e
> FATAL: Could not checkout c1765c71ba4394597409de790bf4529ff97e866e
>
> hudson.plugins.git.GitException
> : Command "git checkout -f c1765c71ba4394597409de790bf4529ff97e866e"
> returned status code 128:
> stdout:
> stderr: fatal: reference is not a tree:
> c1765c71ba4394597409de790bf4529ff97e866e
>
> at
> org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPI
> Impl.java:1866)
>
>
> -Jaikiran
>
> On 22-May-2017, at 12:25 PM, Jan Matèrne (jhm) <ap...@materne.de>
> wrote:
>
> >> On a related note, while we are at this - does Apache infra allow
> the
> > jobs to be run against Windows OS Jenkins agents as well? There are a
> > few issues specifically reported against Windows OS and having the
> job
> > run against linux and Windows OS should give a decent coverage for
> the
> > upstream code.
> >
> > In Jenkins there is the concept of « Matrix » job.
> > Here is the ones for Ant:
> > https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> > Windows/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-
> > Matrix-1.9.x-Windows/>
> > https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> > Linux/
> > <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-
> > 1.9.x-Linux/>
> > AFAIR, it used to be able to do on several different OS. I don’t know
> > why they are split.
> >
> > And I don’t know if it is possible to do it while pulling a PR from
> > github.
>
>
> New buildjob "Ivy-GithubPR-Matrix". I deactivated the old (so we could
> easily switch back).
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR-Matrix/
> Basically a copy of the old job:
> * discard old build jobs (keep 10)
> * git merge support: fail the build if push fails
> * github project: git://github.com/apache/ant-ivy.git
> * git
> -- repository: git://github.com/apache/ant-ivy.git
> -- branches: */master (= default)
> -- clean before checkout
> -- recursively update submodules
> -- build commits submitted for validated merge (= PR support)
> * start build: build pull request to the repository (= PR support)
> * configuration matrix
> -- JDK: JDK 1.7 (latest), JDK 1.8 (latest), JDK 9 b156 with jigsaw
> -- os: label expression = ["ubuntu", "Windows"]
> * abort the build if it's stuck: absolute 20 minutes
> * Lock: Ant
> * build
> -- ant(standard): clean coverage-report
> * publish junit: build/test-report/**
>
>
> Jan
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by J Pai <ja...@gmail.com>.
It looks like there might be some issue with the matrix job(s) https://builds.apache.org/job/Ivy-GithubPR-Matrix/2/console
From what I understand of that log, it seems like the parent matrix job (the one above) is correctly checking out the commit from the submitted PR:
> Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e (master)
> git config core.sparsecheckout # timeout=10
> git checkout -f c1765c71ba4394597409de790bf4529ff97e866e
> git rev-parse origin/master^{commit} # timeout=10
> git rev-list 239bc0b04a95d6c0f82e59c513de36d68c033c6a # timeout=10
However, it then hands off the job execution to individual Windows/Linux jobs and those jobs https://builds.apache.org/job/Ivy-GithubPR-Matrix/jdk=JDK%201.7%20(latest),os=ubuntu/2/console don’t seem to be able to checkout the commit(s) from the PR and fail with error like:
> Fetching upstream changes from https://github.com/apache/ant-ivy/
> git --version # timeout=10
> git fetch --tags --progress
https://github.com/apache/ant-ivy/
+refs/heads/*:refs/remotes/origin/*
Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e (master)
> git config core.sparsecheckout # timeout=10
> git checkout -f c1765c71ba4394597409de790bf4529ff97e866e
FATAL: Could not checkout c1765c71ba4394597409de790bf4529ff97e866e
hudson.plugins.git.GitException
: Command "git checkout -f c1765c71ba4394597409de790bf4529ff97e866e" returned status code 128:
stdout:
stderr: fatal: reference is not a tree: c1765c71ba4394597409de790bf4529ff97e866e
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1866)
-Jaikiran
On 22-May-2017, at 12:25 PM, Jan Matèrne (jhm) <ap...@materne.de> wrote:
>> On a related note, while we are at this - does Apache infra allow the
> jobs to be run against Windows OS Jenkins agents as well? There are a
> few issues specifically reported against Windows OS and having the job
> run against linux and Windows OS should give a decent coverage for the
> upstream code.
>
> In Jenkins there is the concept of « Matrix » job.
> Here is the ones for Ant:
> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> Windows/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-
> Matrix-1.9.x-Windows/>
> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> Linux/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-
> 1.9.x-Linux/>
> AFAIR, it used to be able to do on several different OS. I don’t know
> why they are split.
>
> And I don’t know if it is possible to do it while pulling a PR from
> github.
New buildjob "Ivy-GithubPR-Matrix". I deactivated the old (so we could easily switch back).
https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR-Matrix/
Basically a copy of the old job:
* discard old build jobs (keep 10)
* git merge support: fail the build if push fails
* github project: git://github.com/apache/ant-ivy.git
* git
-- repository: git://github.com/apache/ant-ivy.git
-- branches: */master (= default)
-- clean before checkout
-- recursively update submodules
-- build commits submitted for validated merge (= PR support)
* start build: build pull request to the repository (= PR support)
* configuration matrix
-- JDK: JDK 1.7 (latest), JDK 1.8 (latest), JDK 9 b156 with jigsaw
-- os: label expression = ["ubuntu", "Windows"]
* abort the build if it's stuck: absolute 20 minutes
* Lock: Ant
* build
-- ant(standard): clean coverage-report
* publish junit: build/test-report/**
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Ivy - Buildjobs/PreCommit
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
> > On a related note, while we are at this - does Apache infra allow the
> jobs to be run against Windows OS Jenkins agents as well? There are a
> few issues specifically reported against Windows OS and having the job
> run against linux and Windows OS should give a decent coverage for the
> upstream code.
>
> In Jenkins there is the concept of « Matrix » job.
> Here is the ones for Ant:
> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> Windows/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-
> Matrix-1.9.x-Windows/>
> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> Linux/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-
> 1.9.x-Linux/>
> AFAIR, it used to be able to do on several different OS. I don’t know
> why they are split.
>
> And I don’t know if it is possible to do it while pulling a PR from
> github.
New buildjob "Ivy-GithubPR-Matrix". I deactivated the old (so we could easily switch back).
https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR-Matrix/
Basically a copy of the old job:
* discard old build jobs (keep 10)
* git merge support: fail the build if push fails
* github project: git://github.com/apache/ant-ivy.git
* git
-- repository: git://github.com/apache/ant-ivy.git
-- branches: */master (= default)
-- clean before checkout
-- recursively update submodules
-- build commits submitted for validated merge (= PR support)
* start build: build pull request to the repository (= PR support)
* configuration matrix
-- JDK: JDK 1.7 (latest), JDK 1.8 (latest), JDK 9 b156 with jigsaw
-- os: label expression = ["ubuntu", "Windows"]
* abort the build if it's stuck: absolute 20 minutes
* Lock: Ant
* build
-- ant(standard): clean coverage-report
* publish junit: build/test-report/**
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by Nicolas Lalevée <ni...@hibnet.org>.
> Le 20 mai 2017 à 04:45, J Pai <ja...@gmail.com> a écrit :
>
> This pre-commit job is now almost functional. It gets triggered whenever there’s a PR and runs the build and tests and reports back if there are any failures.
>
> However, the only thing that’s pending or seems to be an issue is it sometimes doesn’t report back with the status. In these 2 PRs https://github.com/apache/ant-ivy/pull/19 https://github.com/apache/ant-ivy/pull/20 the status was never reported back to github (one of the jobs succeeded and the other failed, so there isn’t a clear hint of when this happens).
I have seen that. In the config I didn’t see any obvious option that fix that.
> Other than that, this entire pre-commit support that was added quickly has helped a lot. Thanks very much for doing that.
>
> On a related note, while we are at this - does Apache infra allow the jobs to be run against Windows OS Jenkins agents as well? There are a few issues specifically reported against Windows OS and having the job run against linux and Windows OS should give a decent coverage for the upstream code.
In Jenkins there is the concept of « Matrix » job.
Here is the ones for Ant:
https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Windows/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Windows/>
https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Linux/ <https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-Linux/>
AFAIR, it used to be able to do on several different OS. I don’t know why they are split.
And I don’t know if it is possible to do it while pulling a PR from github.
Nicolas
>
> -Jaikiran
>
> On 18-May-2017, at 4:03 PM, Nicolas Lalevée <ni...@hibnet.org> wrote:
>
> I have changed the config of the build so it does a build, then checkstyle, then findbugs, and then the unit tests.
>
> Nicolas
>
>> Le 18 mai 2017 à 08:21, J Pai <ja...@gmail.com> a écrit :
>>
>> Now that the findbugs URL issue has been resolved with this PR[1] being merged, maybe we should change the targets that get run via this pre commit job to be just:
>>
>> ant clean test
>>
>> and as a start, see how it goes with the PR integration process?
>>
>> [1] https://github.com/apache/ant-ivy/pull/16 <https://github.com/apache/ant-ivy/pull/16>
>>
>> -Jaikiran
>>
>> On 17-May-2017, at 6:59 PM, Nicolas Lalevée <nicolas.lalevee@hibnet.org <ma...@hibnet.org>> wrote:
>>
>> Seems to be a classpath issue where two ivy.jar are loaded. Considering the full console log, probably due to init-ivy called twice, a consequence of Ant not computing one unified tree of tasks to call, but a list of trees of the tasks on the command line.
>>
>> The build dedicated to check the style of Ivy is just calling: ant findbugs checkstyle-internal
>> https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check> <https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check>>
>> But it seems broken too due to some broken download link. The init-findbug task needs to be fixed.
>>
>> Nicolas
>>
>>> Le 17 mai 2017 à 14:11, Jan Matèrne (jhm) <ap...@materne.de> a écrit :
>>>
>>> My last test result:
>>> The Jenkins job could not load Findbugs. So I have deactivated that for the moment.
>>>
>>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
>>> ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report
>>> resolve:
>>> BUILD FAILED
>>> /.../build.xml:184: java.lang.ClassCastException: org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast to org.apache.ivy.core.module.descriptor.ModuleDescriptor
>>> at org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
>>> at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
>>> at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
>>> at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
>>> at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)
>>>
>>> ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
>>> not run due to prior problems
>>>
>>>
>>> Some ideas?
>>>
>>>
>>> Jan
>>>
>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>>> Gesendet: Mittwoch, 17. Mai 2017 13:18
>>>> An: Ant Developers List
>>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>>
>>>> Updated the same PR and that triggered this job
>>>> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
>>>> to a host not being resolvable. This job ran on node called H15
>>>> https://builds.apache.org/computer/H15/ whereas the first job which had
>>>> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
>>>> all nodes are not equal and perhaps this job needs to be
>>>> assigned/categorized to certain node groups?
>>>>
>>>> -Jaikiran
>>>> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>>> wrote:
>>>>
>>>> Thanks, I changed the job to run:
>>>>
>>>> ant clean jar sources findbugs checkstyle-internal coverage-report ant
>>>> -f build-release.xml -Drat.failOnError=false rat
>>>>
>>>> Please try again ;)
>>>>
>>>>
>>>> Jan
>>>>
>>>>
>>>>> -----Ursprüngliche Nachricht-----
>>>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>>>> Gesendet: Mittwoch, 17. Mai 2017 10:53
>>>>> An: Ant Developers List
>>>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>>>
>>>>> It turns out the PR you submitted was to your personal repo instead
>>>> of
>>>>> the apache repo. I just submitted a dummy PR to apache repo
>>>>> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
>>>>> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
>>>>> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
>>>>> tests right now (given how quickly it finished)?
>>>>>
>>>>> This is good start to getting this working. Thanks for getting this
>>>>> setup :)
>>>>>
>>>>> -Jaikiran
>>>>>
>>>>>
>>>>> On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
>>>>>
>>>>> Doesn’t look like it got triggered in Jenkins.
>>>>>
>>>>> -Jaikiran
>>>>> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>>>> wrote:
>>>>>
>>>>>> I read the wiki page
>>>> https://wiki.apache.org/general/PreCommitBuilds,
>>>>>> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
>>>>>> had a look at some other PreCommit-jobs.
>>>>>> For me this works like that:
>>>>>> 1. The PreCommit-Admin job checks regularly on for new patches in
>>>>> Jira.
>>>>>> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
>>>>>> file-ID as argument.
>>>>>> 3. The job does the rest.
>>>>>>
>>>>>> That means the job itself has to apply the patchfile - and of course
>>>>>> run the build.
>>>>>>
>>>>>> On the other hand I found a blog post from infra
>>>>>> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
>>>>>> and set up an according job
>>>>>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
>>>>>> This job uses the Github integration by Cloudbees Enterprise plugin.
>>>>>> So next step for test would be a new/updated PR ...
>>>>>
>>>>> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
>>>>> Now ... wait ;)
>>>>>
>>>>> Jan
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>>> commands, e-mail: dev-help@ant.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>>> commands, e-mail: dev-help@ant.apache.org
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>> commands, e-mail: dev-help@ant.apache.org
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org <ma...@ant.apache.org>
>> For additional commands, e-mail: dev-help@ant.apache.org <ma...@ant.apache.org>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
Re: Ivy - Buildjobs/PreCommit
Posted by J Pai <ja...@gmail.com>.
This pre-commit job is now almost functional. It gets triggered whenever there’s a PR and runs the build and tests and reports back if there are any failures.
However, the only thing that’s pending or seems to be an issue is it sometimes doesn’t report back with the status. In these 2 PRs https://github.com/apache/ant-ivy/pull/19 https://github.com/apache/ant-ivy/pull/20 the status was never reported back to github (one of the jobs succeeded and the other failed, so there isn’t a clear hint of when this happens).
Other than that, this entire pre-commit support that was added quickly has helped a lot. Thanks very much for doing that.
On a related note, while we are at this - does Apache infra allow the jobs to be run against Windows OS Jenkins agents as well? There are a few issues specifically reported against Windows OS and having the job run against linux and Windows OS should give a decent coverage for the upstream code.
-Jaikiran
On 18-May-2017, at 4:03 PM, Nicolas Lalevée <ni...@hibnet.org> wrote:
I have changed the config of the build so it does a build, then checkstyle, then findbugs, and then the unit tests.
Nicolas
> Le 18 mai 2017 à 08:21, J Pai <ja...@gmail.com> a écrit :
>
> Now that the findbugs URL issue has been resolved with this PR[1] being merged, maybe we should change the targets that get run via this pre commit job to be just:
>
> ant clean test
>
> and as a start, see how it goes with the PR integration process?
>
> [1] https://github.com/apache/ant-ivy/pull/16 <https://github.com/apache/ant-ivy/pull/16>
>
> -Jaikiran
>
> On 17-May-2017, at 6:59 PM, Nicolas Lalevée <nicolas.lalevee@hibnet.org <ma...@hibnet.org>> wrote:
>
> Seems to be a classpath issue where two ivy.jar are loaded. Considering the full console log, probably due to init-ivy called twice, a consequence of Ant not computing one unified tree of tasks to call, but a list of trees of the tasks on the command line.
>
> The build dedicated to check the style of Ivy is just calling: ant findbugs checkstyle-internal
> https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check> <https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check>>
> But it seems broken too due to some broken download link. The init-findbug task needs to be fixed.
>
> Nicolas
>
>> Le 17 mai 2017 à 14:11, Jan Matèrne (jhm) <ap...@materne.de> a écrit :
>>
>> My last test result:
>> The Jenkins job could not load Findbugs. So I have deactivated that for the moment.
>>
>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
>> ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report
>> resolve:
>> BUILD FAILED
>> /.../build.xml:184: java.lang.ClassCastException: org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast to org.apache.ivy.core.module.descriptor.ModuleDescriptor
>> at org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
>> at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
>> at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
>> at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
>> at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)
>>
>> ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
>> not run due to prior problems
>>
>>
>> Some ideas?
>>
>>
>> Jan
>>
>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>> Gesendet: Mittwoch, 17. Mai 2017 13:18
>>> An: Ant Developers List
>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>
>>> Updated the same PR and that triggered this job
>>> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
>>> to a host not being resolvable. This job ran on node called H15
>>> https://builds.apache.org/computer/H15/ whereas the first job which had
>>> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
>>> all nodes are not equal and perhaps this job needs to be
>>> assigned/categorized to certain node groups?
>>>
>>> -Jaikiran
>>> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>> wrote:
>>>
>>> Thanks, I changed the job to run:
>>>
>>> ant clean jar sources findbugs checkstyle-internal coverage-report ant
>>> -f build-release.xml -Drat.failOnError=false rat
>>>
>>> Please try again ;)
>>>
>>>
>>> Jan
>>>
>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>>> Gesendet: Mittwoch, 17. Mai 2017 10:53
>>>> An: Ant Developers List
>>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>>
>>>> It turns out the PR you submitted was to your personal repo instead
>>> of
>>>> the apache repo. I just submitted a dummy PR to apache repo
>>>> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
>>>> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
>>>> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
>>>> tests right now (given how quickly it finished)?
>>>>
>>>> This is good start to getting this working. Thanks for getting this
>>>> setup :)
>>>>
>>>> -Jaikiran
>>>>
>>>>
>>>> On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
>>>>
>>>> Doesn’t look like it got triggered in Jenkins.
>>>>
>>>> -Jaikiran
>>>> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>>> wrote:
>>>>
>>>>> I read the wiki page
>>> https://wiki.apache.org/general/PreCommitBuilds,
>>>>> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
>>>>> had a look at some other PreCommit-jobs.
>>>>> For me this works like that:
>>>>> 1. The PreCommit-Admin job checks regularly on for new patches in
>>>> Jira.
>>>>> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
>>>>> file-ID as argument.
>>>>> 3. The job does the rest.
>>>>>
>>>>> That means the job itself has to apply the patchfile - and of course
>>>>> run the build.
>>>>>
>>>>> On the other hand I found a blog post from infra
>>>>> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
>>>>> and set up an according job
>>>>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
>>>>> This job uses the Github integration by Cloudbees Enterprise plugin.
>>>>> So next step for test would be a new/updated PR ...
>>>>
>>>> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
>>>> Now ... wait ;)
>>>>
>>>> Jan
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>> commands, e-mail: dev-help@ant.apache.org
>>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org <ma...@ant.apache.org>
> For additional commands, e-mail: dev-help@ant.apache.org <ma...@ant.apache.org>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by Nicolas Lalevée <ni...@hibnet.org>.
I have changed the config of the build so it does a build, then checkstyle, then findbugs, and then the unit tests.
Nicolas
> Le 18 mai 2017 à 08:21, J Pai <ja...@gmail.com> a écrit :
>
> Now that the findbugs URL issue has been resolved with this PR[1] being merged, maybe we should change the targets that get run via this pre commit job to be just:
>
> ant clean test
>
> and as a start, see how it goes with the PR integration process?
>
> [1] https://github.com/apache/ant-ivy/pull/16 <https://github.com/apache/ant-ivy/pull/16>
>
> -Jaikiran
>
> On 17-May-2017, at 6:59 PM, Nicolas Lalevée <nicolas.lalevee@hibnet.org <ma...@hibnet.org>> wrote:
>
> Seems to be a classpath issue where two ivy.jar are loaded. Considering the full console log, probably due to init-ivy called twice, a consequence of Ant not computing one unified tree of tasks to call, but a list of trees of the tasks on the command line.
>
> The build dedicated to check the style of Ivy is just calling: ant findbugs checkstyle-internal
> https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check> <https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check>>
> But it seems broken too due to some broken download link. The init-findbug task needs to be fixed.
>
> Nicolas
>
>> Le 17 mai 2017 à 14:11, Jan Matèrne (jhm) <ap...@materne.de> a écrit :
>>
>> My last test result:
>> The Jenkins job could not load Findbugs. So I have deactivated that for the moment.
>>
>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
>> ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report
>> resolve:
>> BUILD FAILED
>> /.../build.xml:184: java.lang.ClassCastException: org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast to org.apache.ivy.core.module.descriptor.ModuleDescriptor
>> at org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
>> at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
>> at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
>> at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
>> at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)
>>
>> ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
>> not run due to prior problems
>>
>>
>> Some ideas?
>>
>>
>> Jan
>>
>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>> Gesendet: Mittwoch, 17. Mai 2017 13:18
>>> An: Ant Developers List
>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>
>>> Updated the same PR and that triggered this job
>>> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
>>> to a host not being resolvable. This job ran on node called H15
>>> https://builds.apache.org/computer/H15/ whereas the first job which had
>>> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
>>> all nodes are not equal and perhaps this job needs to be
>>> assigned/categorized to certain node groups?
>>>
>>> -Jaikiran
>>> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>> wrote:
>>>
>>> Thanks, I changed the job to run:
>>>
>>> ant clean jar sources findbugs checkstyle-internal coverage-report ant
>>> -f build-release.xml -Drat.failOnError=false rat
>>>
>>> Please try again ;)
>>>
>>>
>>> Jan
>>>
>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>>> Gesendet: Mittwoch, 17. Mai 2017 10:53
>>>> An: Ant Developers List
>>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>>
>>>> It turns out the PR you submitted was to your personal repo instead
>>> of
>>>> the apache repo. I just submitted a dummy PR to apache repo
>>>> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
>>>> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
>>>> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
>>>> tests right now (given how quickly it finished)?
>>>>
>>>> This is good start to getting this working. Thanks for getting this
>>>> setup :)
>>>>
>>>> -Jaikiran
>>>>
>>>>
>>>> On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
>>>>
>>>> Doesn’t look like it got triggered in Jenkins.
>>>>
>>>> -Jaikiran
>>>> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>>> wrote:
>>>>
>>>>> I read the wiki page
>>> https://wiki.apache.org/general/PreCommitBuilds,
>>>>> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
>>>>> had a look at some other PreCommit-jobs.
>>>>> For me this works like that:
>>>>> 1. The PreCommit-Admin job checks regularly on for new patches in
>>>> Jira.
>>>>> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
>>>>> file-ID as argument.
>>>>> 3. The job does the rest.
>>>>>
>>>>> That means the job itself has to apply the patchfile - and of course
>>>>> run the build.
>>>>>
>>>>> On the other hand I found a blog post from infra
>>>>> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
>>>>> and set up an according job
>>>>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
>>>>> This job uses the Github integration by Cloudbees Enterprise plugin.
>>>>> So next step for test would be a new/updated PR ...
>>>>
>>>> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
>>>> Now ... wait ;)
>>>>
>>>> Jan
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>> commands, e-mail: dev-help@ant.apache.org
>>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org <ma...@ant.apache.org>
> For additional commands, e-mail: dev-help@ant.apache.org <ma...@ant.apache.org>
Re: Ivy - Buildjobs/PreCommit
Posted by J Pai <ja...@gmail.com>.
Now that the findbugs URL issue has been resolved with this PR[1] being merged, maybe we should change the targets that get run via this pre commit job to be just:
ant clean test
and as a start, see how it goes with the PR integration process?
[1] https://github.com/apache/ant-ivy/pull/16
-Jaikiran
On 17-May-2017, at 6:59 PM, Nicolas Lalevée <ni...@hibnet.org> wrote:
Seems to be a classpath issue where two ivy.jar are loaded. Considering the full console log, probably due to init-ivy called twice, a consequence of Ant not computing one unified tree of tasks to call, but a list of trees of the tasks on the command line.
The build dedicated to check the style of Ivy is just calling: ant findbugs checkstyle-internal
https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check>
But it seems broken too due to some broken download link. The init-findbug task needs to be fixed.
Nicolas
> Le 17 mai 2017 à 14:11, Jan Matèrne (jhm) <ap...@materne.de> a écrit :
>
> My last test result:
> The Jenkins job could not load Findbugs. So I have deactivated that for the moment.
>
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
> ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report
> resolve:
> BUILD FAILED
> /.../build.xml:184: java.lang.ClassCastException: org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast to org.apache.ivy.core.module.descriptor.ModuleDescriptor
> at org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
> at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
> at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
> at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
> at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)
>
> ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
> not run due to prior problems
>
>
> Some ideas?
>
>
> Jan
>
>
>> -----Ursprüngliche Nachricht-----
>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>> Gesendet: Mittwoch, 17. Mai 2017 13:18
>> An: Ant Developers List
>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>
>> Updated the same PR and that triggered this job
>> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
>> to a host not being resolvable. This job ran on node called H15
>> https://builds.apache.org/computer/H15/ whereas the first job which had
>> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
>> all nodes are not equal and perhaps this job needs to be
>> assigned/categorized to certain node groups?
>>
>> -Jaikiran
>> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <ap...@materne.de>
>> wrote:
>>
>> Thanks, I changed the job to run:
>>
>> ant clean jar sources findbugs checkstyle-internal coverage-report ant
>> -f build-release.xml -Drat.failOnError=false rat
>>
>> Please try again ;)
>>
>>
>> Jan
>>
>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>> Gesendet: Mittwoch, 17. Mai 2017 10:53
>>> An: Ant Developers List
>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>
>>> It turns out the PR you submitted was to your personal repo instead
>> of
>>> the apache repo. I just submitted a dummy PR to apache repo
>>> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
>>> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
>>> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
>>> tests right now (given how quickly it finished)?
>>>
>>> This is good start to getting this working. Thanks for getting this
>>> setup :)
>>>
>>> -Jaikiran
>>>
>>>
>>> On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
>>>
>>> Doesn’t look like it got triggered in Jenkins.
>>>
>>> -Jaikiran
>>> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>> wrote:
>>>
>>>> I read the wiki page
>> https://wiki.apache.org/general/PreCommitBuilds,
>>>> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
>>>> had a look at some other PreCommit-jobs.
>>>> For me this works like that:
>>>> 1. The PreCommit-Admin job checks regularly on for new patches in
>>> Jira.
>>>> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
>>>> file-ID as argument.
>>>> 3. The job does the rest.
>>>>
>>>> That means the job itself has to apply the patchfile - and of course
>>>> run the build.
>>>>
>>>> On the other hand I found a blog post from infra
>>>> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
>>>> and set up an according job
>>>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
>>>> This job uses the Github integration by Cloudbees Enterprise plugin.
>>>> So next step for test would be a new/updated PR ...
>>>
>>> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
>>> Now ... wait ;)
>>>
>>> Jan
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by J Pai <ja...@gmail.com>.
I just submitted a PR https://github.com/apache/ant-ivy/pull/16 which I think should fix the init-findbug task.
-Jaikiran
On 17-May-2017, at 6:59 PM, Nicolas Lalevée <ni...@hibnet.org> wrote:
The build dedicated to check the style of Ivy is just calling: ant findbugs checkstyle-internal
https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check>
But it seems broken too due to some broken download link. The init-findbug task needs to be fixed.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by Nicolas Lalevée <ni...@hibnet.org>.
Seems to be a classpath issue where two ivy.jar are loaded. Considering the full console log, probably due to init-ivy called twice, a consequence of Ant not computing one unified tree of tasks to call, but a list of trees of the tasks on the command line.
The build dedicated to check the style of Ivy is just calling: ant findbugs checkstyle-internal
https://builds.apache.org/view/A/view/Ant/job/Ivy-check <https://builds.apache.org/view/A/view/Ant/job/Ivy-check>
But it seems broken too due to some broken download link. The init-findbug task needs to be fixed.
Nicolas
> Le 17 mai 2017 à 14:11, Jan Matèrne (jhm) <ap...@materne.de> a écrit :
>
> My last test result:
> The Jenkins job could not load Findbugs. So I have deactivated that for the moment.
>
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
> ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report
> resolve:
> BUILD FAILED
> /.../build.xml:184: java.lang.ClassCastException: org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast to org.apache.ivy.core.module.descriptor.ModuleDescriptor
> at org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
> at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
> at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
> at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
> at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)
>
> ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
> not run due to prior problems
>
>
> Some ideas?
>
>
> Jan
>
>
>> -----Ursprüngliche Nachricht-----
>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>> Gesendet: Mittwoch, 17. Mai 2017 13:18
>> An: Ant Developers List
>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>
>> Updated the same PR and that triggered this job
>> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
>> to a host not being resolvable. This job ran on node called H15
>> https://builds.apache.org/computer/H15/ whereas the first job which had
>> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
>> all nodes are not equal and perhaps this job needs to be
>> assigned/categorized to certain node groups?
>>
>> -Jaikiran
>> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <ap...@materne.de>
>> wrote:
>>
>> Thanks, I changed the job to run:
>>
>> ant clean jar sources findbugs checkstyle-internal coverage-report ant
>> -f build-release.xml -Drat.failOnError=false rat
>>
>> Please try again ;)
>>
>>
>> Jan
>>
>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: J Pai [mailto:jai.forums2013@gmail.com]
>>> Gesendet: Mittwoch, 17. Mai 2017 10:53
>>> An: Ant Developers List
>>> Betreff: Re: Ivy - Buildjobs/PreCommit
>>>
>>> It turns out the PR you submitted was to your personal repo instead
>> of
>>> the apache repo. I just submitted a dummy PR to apache repo
>>> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
>>> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
>>> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
>>> tests right now (given how quickly it finished)?
>>>
>>> This is good start to getting this working. Thanks for getting this
>>> setup :)
>>>
>>> -Jaikiran
>>>
>>>
>>> On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
>>>
>>> Doesn’t look like it got triggered in Jenkins.
>>>
>>> -Jaikiran
>>> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
>>> wrote:
>>>
>>>> I read the wiki page
>> https://wiki.apache.org/general/PreCommitBuilds,
>>>> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
>>>> had a look at some other PreCommit-jobs.
>>>> For me this works like that:
>>>> 1. The PreCommit-Admin job checks regularly on for new patches in
>>> Jira.
>>>> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
>>>> file-ID as argument.
>>>> 3. The job does the rest.
>>>>
>>>> That means the job itself has to apply the patchfile - and of course
>>>> run the build.
>>>>
>>>> On the other hand I found a blog post from infra
>>>> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
>>>> and set up an according job
>>>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
>>>> This job uses the Github integration by Cloudbees Enterprise plugin.
>>>> So next step for test would be a new/updated PR ...
>>>
>>> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
>>> Now ... wait ;)
>>>
>>> Jan
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>> commands, e-mail: dev-help@ant.apache.org
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>> commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
AW: Ivy - Buildjobs/PreCommit
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
My last test result:
The Jenkins job could not load Findbugs. So I have deactivated that for the moment.
https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report
resolve:
BUILD FAILED
/.../build.xml:184: java.lang.ClassCastException: org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast to org.apache.ivy.core.module.descriptor.ModuleDescriptor
at org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)
ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
not run due to prior problems
Some ideas?
Jan
> -----Ursprüngliche Nachricht-----
> Von: J Pai [mailto:jai.forums2013@gmail.com]
> Gesendet: Mittwoch, 17. Mai 2017 13:18
> An: Ant Developers List
> Betreff: Re: Ivy - Buildjobs/PreCommit
>
> Updated the same PR and that triggered this job
> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
> to a host not being resolvable. This job ran on node called H15
> https://builds.apache.org/computer/H15/ whereas the first job which had
> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
> all nodes are not equal and perhaps this job needs to be
> assigned/categorized to certain node groups?
>
> -Jaikiran
> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <ap...@materne.de>
> wrote:
>
> Thanks, I changed the job to run:
>
> ant clean jar sources findbugs checkstyle-internal coverage-report ant
> -f build-release.xml -Drat.failOnError=false rat
>
> Please try again ;)
>
>
> Jan
>
>
> > -----Ursprüngliche Nachricht-----
> > Von: J Pai [mailto:jai.forums2013@gmail.com]
> > Gesendet: Mittwoch, 17. Mai 2017 10:53
> > An: Ant Developers List
> > Betreff: Re: Ivy - Buildjobs/PreCommit
> >
> > It turns out the PR you submitted was to your personal repo instead
> of
> > the apache repo. I just submitted a dummy PR to apache repo
> > https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
> > the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
> > GithubPR/1/ automagically :) I’m guessing this job isn’t running any
> > tests right now (given how quickly it finished)?
> >
> > This is good start to getting this working. Thanks for getting this
> > setup :)
> >
> > -Jaikiran
> >
> >
> > On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
> >
> > Doesn’t look like it got triggered in Jenkins.
> >
> > -Jaikiran
> > On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
> > wrote:
> >
> >> I read the wiki page
> https://wiki.apache.org/general/PreCommitBuilds,
> >> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> >> had a look at some other PreCommit-jobs.
> >> For me this works like that:
> >> 1. The PreCommit-Admin job checks regularly on for new patches in
> > Jira.
> >> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
> >> file-ID as argument.
> >> 3. The job does the rest.
> >>
> >> That means the job itself has to apply the patchfile - and of course
> >> run the build.
> >>
> >> On the other hand I found a blog post from infra
> >> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
> >> and set up an according job
> >> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> >> This job uses the Github integration by Cloudbees Enterprise plugin.
> >> So next step for test would be a new/updated PR ...
> >
> > I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
> > Now ... wait ;)
> >
> > Jan
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> > commands, e-mail: dev-help@ant.apache.org
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> > commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by J Pai <ja...@gmail.com>.
Updated the same PR and that triggered this job https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due to a host not being resolvable. This job ran on node called H15 https://builds.apache.org/computer/H15/ whereas the first job which had succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe all nodes are not equal and perhaps this job needs to be assigned/categorized to certain node groups?
-Jaikiran
On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) <ap...@materne.de> wrote:
Thanks, I changed the job to run:
ant clean jar sources findbugs checkstyle-internal coverage-report
ant -f build-release.xml -Drat.failOnError=false rat
Please try again ;)
Jan
> -----Ursprüngliche Nachricht-----
> Von: J Pai [mailto:jai.forums2013@gmail.com]
> Gesendet: Mittwoch, 17. Mai 2017 10:53
> An: Ant Developers List
> Betreff: Re: Ivy - Buildjobs/PreCommit
>
> It turns out the PR you submitted was to your personal repo instead of
> the apache repo. I just submitted a dummy PR to apache repo
> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
> tests right now (given how quickly it finished)?
>
> This is good start to getting this working. Thanks for getting this
> setup :)
>
> -Jaikiran
>
>
> On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
>
> Doesn’t look like it got triggered in Jenkins.
>
> -Jaikiran
> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
> wrote:
>
>> I read the wiki page https://wiki.apache.org/general/PreCommitBuilds,
>> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
>> had a look at some other PreCommit-jobs.
>> For me this works like that:
>> 1. The PreCommit-Admin job checks regularly on for new patches in
> Jira.
>> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
>> file-ID as argument.
>> 3. The job does the rest.
>>
>> That means the job itself has to apply the patchfile - and of course
>> run the build.
>>
>> On the other hand I found a blog post from infra
>> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
>> and set up an according job
>> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
>> This job uses the Github integration by Cloudbees Enterprise plugin.
>> So next step for test would be a new/updated PR ...
>
> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
> Now ... wait ;)
>
> Jan
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Ivy - Buildjobs/PreCommit
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
Thanks, I changed the job to run:
ant clean jar sources findbugs checkstyle-internal coverage-report
ant -f build-release.xml -Drat.failOnError=false rat
Please try again ;)
Jan
> -----Ursprüngliche Nachricht-----
> Von: J Pai [mailto:jai.forums2013@gmail.com]
> Gesendet: Mittwoch, 17. Mai 2017 10:53
> An: Ant Developers List
> Betreff: Re: Ivy - Buildjobs/PreCommit
>
> It turns out the PR you submitted was to your personal repo instead of
> the apache repo. I just submitted a dummy PR to apache repo
> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
> tests right now (given how quickly it finished)?
>
> This is good start to getting this working. Thanks for getting this
> setup :)
>
> -Jaikiran
>
>
> On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
>
> Doesn’t look like it got triggered in Jenkins.
>
> -Jaikiran
> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de>
> wrote:
>
> > I read the wiki page https://wiki.apache.org/general/PreCommitBuilds,
> > the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> > had a look at some other PreCommit-jobs.
> > For me this works like that:
> > 1. The PreCommit-Admin job checks regularly on for new patches in
> Jira.
> > 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
> > file-ID as argument.
> > 3. The job does the rest.
> >
> > That means the job itself has to apply the patchfile - and of course
> > run the build.
> >
> > On the other hand I found a blog post from infra
> > https://blogs.apache.org/infra/entry/github_pull_request_builds_now
> > and set up an according job
> > https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> > This job uses the Github integration by Cloudbees Enterprise plugin.
> > So next step for test would be a new/updated PR ...
>
> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
> Now ... wait ;)
>
> Jan
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by J Pai <ja...@gmail.com>.
It turns out the PR you submitted was to your personal repo instead of the apache repo. I just submitted a dummy PR to apache repo https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/1/ automagically :) I’m guessing this job isn’t running any tests right now (given how quickly it finished)?
This is good start to getting this working. Thanks for getting this setup :)
-Jaikiran
On 17-May-2017, at 2:07 PM, J Pai <ja...@gmail.com> wrote:
Doesn’t look like it got triggered in Jenkins.
-Jaikiran
On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de> wrote:
> I read the wiki page https://wiki.apache.org/general/PreCommitBuilds,
> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> had a look at some other PreCommit-jobs.
> For me this works like that:
> 1. The PreCommit-Admin job checks regularly on for new patches in Jira.
> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and file-ID
> as argument.
> 3. The job does the rest.
>
> That means the job itself has to apply the patchfile - and of course
> run the build.
>
> On the other hand I found a blog post from infra
> https://blogs.apache.org/infra/entry/github_pull_request_builds_now and
> set up an according job
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> This job uses the Github integration by Cloudbees Enterprise plugin.
> So next step for test would be a new/updated PR ...
I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
Now ... wait ;)
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy - Buildjobs/PreCommit
Posted by J Pai <ja...@gmail.com>.
Doesn’t look like it got triggered in Jenkins.
-Jaikiran
On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) <ap...@materne.de> wrote:
> I read the wiki page https://wiki.apache.org/general/PreCommitBuilds,
> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> had a look at some other PreCommit-jobs.
> For me this works like that:
> 1. The PreCommit-Admin job checks regularly on for new patches in Jira.
> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and file-ID
> as argument.
> 3. The job does the rest.
>
> That means the job itself has to apply the patchfile - and of course
> run the build.
>
> On the other hand I found a blog post from infra
> https://blogs.apache.org/infra/entry/github_pull_request_builds_now and
> set up an according job
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> This job uses the Github integration by Cloudbees Enterprise plugin.
> So next step for test would be a new/updated PR ...
I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
Now ... wait ;)
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Ivy - Buildjobs/PreCommit
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
> I read the wiki page https://wiki.apache.org/general/PreCommitBuilds,
> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> had a look at some other PreCommit-jobs.
> For me this works like that:
> 1. The PreCommit-Admin job checks regularly on for new patches in Jira.
> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and file-ID
> as argument.
> 3. The job does the rest.
>
> That means the job itself has to apply the patchfile - and of course
> run the build.
>
> On the other hand I found a blog post from infra
> https://blogs.apache.org/infra/entry/github_pull_request_builds_now and
> set up an according job
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> This job uses the Github integration by Cloudbees Enterprise plugin.
> So next step for test would be a new/updated PR ...
I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
Now ... wait ;)
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org