You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by sureshms <gi...@git.apache.org> on 2015/11/04 01:05:19 UTC
[GitHub] storm pull request: STORM-1164. Code cleanup for typos, warnings a...
GitHub user sureshms opened a pull request:
https://github.com/apache/storm/pull/852
STORM-1164. Code cleanup for typos, warnings and conciseness
A lot of cleanup in this patch. Let me know if this needs to be split into smaller manageable patches. This should not make the existing patches that is in progress more complicated to merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshms/incubator-storm STORM-1164
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #852
----
commit 8b48644e1fab5e614f694cb5b464cd9879063418
Author: Suresh Srinivas <su...@yahoo-inc.com>
Date: 2015-11-04T00:03:16Z
STORM-1164. Code cleanup for typos, warnings and conciseness
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1164. Code cleanup for typos, warnings a...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/852#issuecomment-155227113
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1164. Code cleanup for typos, warnings a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1164. Code cleanup for typos, warnings a...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/852#issuecomment-155232099
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1164. Code cleanup for typos, warnings a...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/852#issuecomment-154200323
These look really good. Could you please upmerge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---