You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by do...@apache.org on 2002/06/07 03:48:01 UTC

cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

donaldp     2002/06/06 18:48:00

  Removed:     antlib/src/test/org/apache/antlib/core/test for-each.ant
                        ForEachTaskTestCase.java
               antlib/src/java/org/apache/antlib/core ForEachTask.java
  Log:
  Just say No

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Adam Murdoch <ad...@apache.org>.
On Fri, 7 Jun 2002 17:00, Peter Donald wrote:
> At 04:46 PM 6/7/2002 +1000, you wrote:
> >On Fri, 7 Jun 2002 14:51, Peter Donald wrote:
> > > At 02:40 PM 6/7/2002 +1000, you wrote:
> > > >That's probably true - but we don't know that yet.  Let's keep the
> > > > task until we actually *do* have templating.  Then, we can compare
> > > > them for usability. It may well turn out that they both have a place.
> > >
> > > I would prefer not to put another hack in unless it is furthering
> > > development which I don't believe the task would.
> >
> >I don't understand why the <for-each> task is a hack.  Seems like a
> >straightforward operation, really:  Do some stuff for each member of a
> > list.
>
> Essentially as its use in any real context basically requires recursive
> property resolution which has been vetoed many a time on ant-dev ;)

With mutable properties, and the improved property scoping we have now, you 
should be able to do all kinds of good stuff without resorting to recursive 
property resolution.   

I do agree that <for-each> is a crappy solution to templating.  But templates 
and iteration aren't the same thing, there's just a big overlap in the kinds 
of problems they can solve.  I want to keep <for-each>, because I think it 
will continue to prove useful even after we have templating in place.

-- 
Adam

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Peter Donald <pe...@apache.org>.
At 04:46 PM 6/7/2002 +1000, you wrote:
>On Fri, 7 Jun 2002 14:51, Peter Donald wrote:
> > At 02:40 PM 6/7/2002 +1000, you wrote:
> > >That's probably true - but we don't know that yet.  Let's keep the task
> > > until we actually *do* have templating.  Then, we can compare them for
> > > usability. It may well turn out that they both have a place.
> >
> > I would prefer not to put another hack in unless it is furthering
> > development which I don't believe the task would.
>
>I don't understand why the <for-each> task is a hack.  Seems like a
>straightforward operation, really:  Do some stuff for each member of a list.

Essentially as its use in any real context basically requires recursive 
property resolution which has been vetoed many a time on ant-dev ;)


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Adam Murdoch <ad...@apache.org>.
On Fri, 7 Jun 2002 14:51, Peter Donald wrote:
> At 02:40 PM 6/7/2002 +1000, you wrote:
> >That's probably true - but we don't know that yet.  Let's keep the task
> > until we actually *do* have templating.  Then, we can compare them for
> > usability. It may well turn out that they both have a place.
>
> I would prefer not to put another hack in unless it is furthering
> development which I don't believe the task would.

I don't understand why the <for-each> task is a hack.  Seems like a 
straightforward operation, really:  Do some stuff for each member of a list.

-- 
Adam

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Peter Donald <pe...@apache.org>.
At 02:40 PM 6/7/2002 +1000, you wrote:
>That's probably true - but we don't know that yet.  Let's keep the task until
>we actually *do* have templating.  Then, we can compare them for usability.
>It may well turn out that they both have a place.

I would prefer not to put another hack in unless it is furthering 
development which I don't believe the task would.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Adam Murdoch <ad...@apache.org>.
On Fri, 7 Jun 2002 12:54, Peter Donald wrote:
> At 12:46 PM 6/7/2002 +1000, you wrote:
> >On Fri, 7 Jun 2002 12:32, Peter Donald wrote:
> > > At 12:29 PM 6/7/2002 +1000, you wrote:
> > > >On Fri, 7 Jun 2002 11:48, donaldp@apache.org wrote:
> > > > > donaldp     2002/06/06 18:48:00
> > > > >
> > > > >   Removed:     antlib/src/test/org/apache/antlib/core/test
> > > > > for-each.ant ForEachTaskTestCase.java
> > > > >                antlib/src/java/org/apache/antlib/core
> > > > > ForEachTask.java Log:
> > > > >   Just say No
> > > >
> > > >*grumble*  Ok, how about putting stuff like this in a non-core antlib,
> > > > then?
> > >
> > > Sure - as long as it is on sourceforge ;)
> >
> >Which is exactly where most of the antlibs are supposed to end up.  In the
> >meantime, what's the problem with them living in the myrmidon tree?
>
> Because its presence is an indication that the container is not yet
> sufficiently advanced and I suspect we will never need when templates are
> in core.

That's probably true - but we don't know that yet.  Let's keep the task until 
we actually *do* have templating.  Then, we can compare them for usability.  
It may well turn out that they both have a place.

-- 
Adam

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Peter Donald <pe...@apache.org>.
At 12:46 PM 6/7/2002 +1000, you wrote:
>On Fri, 7 Jun 2002 12:32, Peter Donald wrote:
> > At 12:29 PM 6/7/2002 +1000, you wrote:
> > >On Fri, 7 Jun 2002 11:48, donaldp@apache.org wrote:
> > > > donaldp     2002/06/06 18:48:00
> > > >
> > > >   Removed:     antlib/src/test/org/apache/antlib/core/test for-each.ant
> > > >                         ForEachTaskTestCase.java
> > > >                antlib/src/java/org/apache/antlib/core ForEachTask.java
> > > >   Log:
> > > >   Just say No
> > >
> > >*grumble*  Ok, how about putting stuff like this in a non-core antlib,
> > > then?
> >
> > Sure - as long as it is on sourceforge ;)
>
>Which is exactly where most of the antlibs are supposed to end up.  In the
>meantime, what's the problem with them living in the myrmidon tree?

Because its presence is an indication that the container is not yet 
sufficiently advanced and I suspect we will never need when templates are 
in core.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Adam Murdoch <ad...@apache.org>.
On Fri, 7 Jun 2002 12:32, Peter Donald wrote:
> At 12:29 PM 6/7/2002 +1000, you wrote:
> >On Fri, 7 Jun 2002 11:48, donaldp@apache.org wrote:
> > > donaldp     2002/06/06 18:48:00
> > >
> > >   Removed:     antlib/src/test/org/apache/antlib/core/test for-each.ant
> > >                         ForEachTaskTestCase.java
> > >                antlib/src/java/org/apache/antlib/core ForEachTask.java
> > >   Log:
> > >   Just say No
> >
> >*grumble*  Ok, how about putting stuff like this in a non-core antlib,
> > then?
>
> Sure - as long as it is on sourceforge ;)

Which is exactly where most of the antlibs are supposed to end up.  In the 
meantime, what's the problem with them living in the myrmidon tree?

-- 
Adam

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Peter Donald <pe...@apache.org>.
At 12:29 PM 6/7/2002 +1000, you wrote:
>On Fri, 7 Jun 2002 11:48, donaldp@apache.org wrote:
> > donaldp     2002/06/06 18:48:00
> >
> >   Removed:     antlib/src/test/org/apache/antlib/core/test for-each.ant
> >                         ForEachTaskTestCase.java
> >                antlib/src/java/org/apache/antlib/core ForEachTask.java
> >   Log:
> >   Just say No
>
>*grumble*  Ok, how about putting stuff like this in a non-core antlib, then?


Sure - as long as it is on sourceforge ;)


>--
>Adam
>
>--
>To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
>For additional commands, e-mail: <ma...@jakarta.apache.org>



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant-myrmidon/antlib/src/java/org/apache/antlib/core ForEachTask.java

Posted by Adam Murdoch <ad...@apache.org>.
On Fri, 7 Jun 2002 11:48, donaldp@apache.org wrote:
> donaldp     2002/06/06 18:48:00
>
>   Removed:     antlib/src/test/org/apache/antlib/core/test for-each.ant
>                         ForEachTaskTestCase.java
>                antlib/src/java/org/apache/antlib/core ForEachTask.java
>   Log:
>   Just say No

*grumble*  Ok, how about putting stuff like this in a non-core antlib, then?

-- 
Adam

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>