[jira] [Commented] (ARIES-682) application-modeller-common-test failure

["Valentin Mahrwald (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052523#comment-13052523 ] 

Valentin Mahrwald commented on ARIES-682:
-----------------------------------------

The underlying problem causing this is that IFiles although being an abstraction across various types of hierchical file systems, have the knack of returning file names with '\' on plain filesystems on Windows and '/' everywhere else. This of course leads to parts of the code ignoring the possibility of '\' and then introducing bugs on Windows.

To fix that I propose changing IFiles to always return unix style file paths.

> application-modeller-common-test failure
> ----------------------------------------
>
>                 Key: ARIES-682
>                 URL: https://issues.apache.org/jira/browse/ARIES-682
>             Project: Aries
>          Issue Type: Bug
>          Components: Application
>         Environment: Windows + cygwin
>            Reporter: Jeremy Hughes
>            Assignee: Valentin Mahrwald
>
> I see two failing tests in application-modeller-common-test - two tests run against a bundle jar which pass, but the same two tests that run against an extracted bundle jar fail. The Blueprint services aren't being found. This is the failure:
> -------------------------------------------------------------------------------
> Test set: org.apache.aries.application.modelling.ModellerTest
> -------------------------------------------------------------------------------
> Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.187 sec <<< FAILURE!
> testParsingOfBundle[0](org.apache.aries.application.modelling.ModellerTest)  Time elapsed: 0.012 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<3> but was:<0>
>     at org.junit.Assert.fail(Assert.java:91)
>     at org.junit.Assert.failNotEquals(Assert.java:645)
>     at org.junit.Assert.assertEquals(Assert.java:126)
>     at org.junit.Assert.assertEquals(Assert.java:470)
>     at org.junit.Assert.assertEquals(Assert.java:454)
>     at org.apache.aries.application.modelling.ModellerTest.checkTestBundleResource(ModellerTest.java:127)
>     at org.apache.aries.application.modelling.ModellerTest.testParsingOfBundle(ModellerTest.java:94)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>     at java.lang.reflect.Method.invoke(Method.java:600)
>     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
>     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
>     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
>     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
>     at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
>     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
>     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
>     at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
>     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
>     at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
>     at org.junit.runners.Suite.runChild(Suite.java:128)
>     at org.junit.runners.Suite.runChild(Suite.java:24)
>     at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
>     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
>     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
>     at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
>     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
>     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
>     at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
>     at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
>     at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
>     at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
>     at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
>     at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>     at java.lang.reflect.Method.invoke(Method.java:600)
>     at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
>     at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira