You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2014/10/01 16:00:47 UTC

[GitHub] incubator-brooklyn pull request: Adds basic instructions for setti...

Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/195#issuecomment-57468014
  
    &lt;opinion&gt;
    I think it's more helpful to squash changes from review comments into the original commit. Whereas the original commit message is a useful reference point, the subsequent ones are just noise.  "PR comments addressed" doesn't tell you anything in six months time when you want to remind yourself why a particular line was changed. Not that this needs to block this pull request being merged.
    &lt;/opinion&gt;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---