You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/10 15:39:14 UTC
[jira] [Commented] (THRIFT-2884) Map does not serialize correctly
for JSON protocol in Go library
[ https://issues.apache.org/jira/browse/THRIFT-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241148#comment-14241148 ]
ASF GitHub Bot commented on THRIFT-2884:
----------------------------------------
GitHub user llhe opened a pull request:
https://github.com/apache/thrift/pull/312
Fix THRIFT-2884 - Map does not serialize correctly for JSON protocol in Go library
Fix THRIFT-2884
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/llhe/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #312
----
commit b68a011f55e613d54771cadd617f31a2492e7602
Author: Liangliang He <ll...@gmail.com>
Date: 2014-12-10T14:35:33Z
Fix THRIFT-2884 - Map does not serialize correctly for JSON protocol in Go library
----
> Map does not serialize correctly for JSON protocol in Go library
> ----------------------------------------------------------------
>
> Key: THRIFT-2884
> URL: https://issues.apache.org/jira/browse/THRIFT-2884
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: He Liangliang
>
> In other language bindings(e.g. Java/PHP/Python etc.), there is a quote for the inner list or map entries, but go binding does not have it. It breaks cross language compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)