You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/19 23:45:27 UTC
[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #1080: stm32: nxstyle fixes
hartmannathan opened a new pull request #1080:
URL: https://github.com/apache/incubator-nuttx/pull/1080
## Summary
arch/arm/include/stm32/irq.h:
arch/arm/src/stm32/hardware/stm32_dma_v1.h:
arch/arm/src/stm32/hardware/stm32_i2c.h:
arch/arm/src/stm32/hardware/stm32_pinmap.h:
arch/arm/src/stm32/stm32_dma.c:
arch/arm/src/stm32/stm32_dumpgpio.c:
arch/arm/src/stm32/stm32_gpio.h:
* nxstyle fixes, mostly long lines
## Impact
No functional changes. Silences numerous nxstyle errors.
## Testing
Changes pass nxstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1080: stm32: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1080:
URL: https://github.com/apache/incubator-nuttx/pull/1080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #1080: stm32: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #1080:
URL: https://github.com/apache/incubator-nuttx/pull/1080#issuecomment-631165204
Why is it saying that the macOS (sim) test was cancelled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1080: stm32: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1080:
URL: https://github.com/apache/incubator-nuttx/pull/1080#issuecomment-631214543
We are not the only ones facing this for macOS especially recently. For example:
https://github.com/scipy/scipy/issues/12016
I noticed it seemed to get more common when we added more targets and the build time increased, but we are well under the cutoff. I can comment on the forums, but for now rebuilding or using judgement is probably the best. There is a job that runs on master so we can catch things there as well post merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #1080: stm32: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #1080:
URL: https://github.com/apache/incubator-nuttx/pull/1080#issuecomment-631271909
> We are not the only ones facing this for macOS especially recently. For example:
> [scipy/scipy#12016](https://github.com/scipy/scipy/issues/12016)
>
> I noticed it seemed to get more common when we added more targets and the build time increased, but we are well under the cutoff. I can comment on the forums, but for now rebuilding or using judgement is probably the best. There is a job that runs on master so we can catch things there as well post merge.
Maybe we should consider detecting which parts of the system are touched by a PR and reducing pre-checks. For example if only a particular architecture is affected, other architectures would not be tested? I don't know if this is feasible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1080: stm32: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1080:
URL: https://github.com/apache/incubator-nuttx/pull/1080#issuecomment-631212024
Yes, it is very strange and happen many time from yesterday. @btashton and @liuguo09 . But the change looks good, let's merge it to unblock your work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org