You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "amichair (via GitHub)" <gi...@apache.org> on 2026/06/08 06:21:10 UTC
[PR] ARIES-2234 Fix deadlock between TopologyManager.importService and Rem… [aries-rsa]
amichair opened a new pull request, #140:
URL: https://github.com/apache/aries-rsa/pull/140
…oteServiceAdminCore.removeImportRegistration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2234 Fix deadlock between TopologyManager.importService and Rem… [aries-rsa]
Posted by "amichair (via GitHub)" <gi...@apache.org>.
amichair merged PR #140:
URL: https://github.com/apache/aries-rsa/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2234 Fix deadlock between TopologyManager.importService and Rem… [aries-rsa]
Posted by "amichair (via GitHub)" <gi...@apache.org>.
amichair commented on code in PR #140:
URL: https://github.com/apache/aries-rsa/pull/140#discussion_r3375479213
##########
rsa/src/main/java/org/apache/aries/rsa/core/RemoteServiceAdminCore.java:
##########
@@ -504,23 +504,22 @@ protected void removeExportRegistration(ExportRegistration eri) {
}
protected void removeImportRegistration(ImportRegistration iri) {
- synchronized (importedServices) {
- LOG.debug("Removing importRegistration {}", iri);
-
- ImportReference importRef = iri.getException() != null ? null : iri.getImportReference();
- if (importRef == null) {
- return;
+ LOG.debug("Removing importRegistration {}", iri);
+ ImportReference importRef = iri.getException() != null ? null : iri.getImportReference();
Review Comment:
Standardized the naming in a separate commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARIES-2234 Fix deadlock between TopologyManager.importService and Rem… [aries-rsa]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #140:
URL: https://github.com/apache/aries-rsa/pull/140#discussion_r3374660777
##########
rsa/src/main/java/org/apache/aries/rsa/core/RemoteServiceAdminCore.java:
##########
@@ -504,23 +504,22 @@ protected void removeExportRegistration(ExportRegistration eri) {
}
protected void removeImportRegistration(ImportRegistration iri) {
- synchronized (importedServices) {
- LOG.debug("Removing importRegistration {}", iri);
-
- ImportReference importRef = iri.getException() != null ? null : iri.getImportReference();
- if (importRef == null) {
- return;
+ LOG.debug("Removing importRegistration {}", iri);
+ ImportReference importRef = iri.getException() != null ? null : iri.getImportReference();
Review Comment:
can we rename `iri` to something more meaningful? it's not a good acronym for `Import Registration`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org