You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/10/28 10:18:40 UTC

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #45: log_mgmt:watermark should be set at last log entry

vrahane commented on a change in pull request #45: log_mgmt:watermark should be set at last log entry
URL: https://github.com/apache/mynewt-mcumgr/pull/45#discussion_r339487518
 
 

 ##########
 File path: cmd/log_mgmt/src/log_mgmt.c
 ##########
 @@ -310,6 +313,11 @@ log_encode_entries(const struct log_mgmt_log *log, CborEncoder *enc,
         return LOG_MGMT_ERR_ENOMEM;
     }
 
+#if LOG_MGMT_READ_WATERMARK_UPDATE
+    if (!rc) {
+        rc = log_mgmt_impl_set_watermark(log, ctxt.last_enc_index);
 
 Review comment:
   Thanks Chris, I’ll take care of this, good catch!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services