You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "nkeywal (JIRA)" <ji...@apache.org> on 2013/02/11 10:23:14 UTC

[jira] [Comment Edited] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead

    [ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575694#comment-13575694 ] 

nkeywal edited comment on HBASE-7462 at 2/11/13 9:22 AM:
---------------------------------------------------------

We should not mock up the ZK itself, just the calls to ZK for this scenario. Ideally again, as it easier said than done :-)
                
      was (Author: nkeywal):
    We should not mock up the ZK itself, just the calls to ZK for this scenario. Ideally again, as it easier to say that to do :-)
                  
> TestDrainingServer is an integration test. It should be a unit test instead
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7462
>                 URL: https://issues.apache.org/jira/browse/HBASE-7462
>             Project: HBase
>          Issue Type: Wish
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Priority: Trivial
>              Labels: noob
>
> TestDrainingServer tests the function that allows to say that a regionserver should not get new regions.
> As it is written today, it's an integration test: it starts & stops a cluster.
> The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira