You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/03/30 14:46:25 UTC
Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt the
bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Bugs: AMBARI-10271
https://issues.apache.org/jira/browse/AMBARI-10271
Repository: ambari
Description
-------
[WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
Diffs
-----
ambari-server/src/main/assemblies/server-windows.xml 8b5483a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
ambari-server/src/main/python/bootstrap.py 111ff46
ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
Diff: https://reviews.apache.org/r/32619/diff/
Testing
-------
tested manyally
Thanks,
Artem Baranchuk
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Artem Baranchuk <ab...@hortonworks.com>.
> On Март 30, 2015, 3:53 п.п., Florian Barca wrote:
> > ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1, line 34
> > <https://reviews.apache.org/r/32619/diff/1/?file=909162#file909162line34>
> >
> > Great that you're handling exceptions here. Hopefully the usage of -Force doesn't destroy any contents in an already created directory.
No -Force doesn't destroy already existing dir
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78208
-----------------------------------------------------------
On Март 30, 2015, 12:46 п.п., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated Март 30, 2015, 12:46 п.п.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
> ambari-server/src/main/python/bootstrap.py 111ff46
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78208
-----------------------------------------------------------
ambari-server/src/main/python/bootstrap.py
<https://reviews.apache.org/r/32619/#comment126718>
Cosmetic: This is the else of "if OSCheck.is_windows_family()"
ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1
<https://reviews.apache.org/r/32619/#comment126720>
Great that you're handling exceptions here. Hopefully the usage of -Force doesn't destroy any contents in an already created directory.
- Florian Barca
On March 30, 2015, 12:46 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 12:46 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
> ambari-server/src/main/python/bootstrap.py 111ff46
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Artem Baranchuk <ab...@hortonworks.com>.
> On Март 31, 2015, 7:09 п.п., Florian Barca wrote:
> > ambari-server/src/main/python/bootstrap.py, line 168
> > <https://reviews.apache.org/r/32619/diff/1/?file=909161#file909161line168>
> >
> > Needs to be -File instead of -Command here
-File doesnt work when we run scripts from python. It will be ok when we wrap powershel by cmd script or run it just from command line. Think we should leave it as -Command for now.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78389
-----------------------------------------------------------
On Апрель 1, 2015, 3:06 п.п., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated Апрель 1, 2015, 3:06 п.п.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/conf/windows/ambari.properties cfe9c3d
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
> ambari-server/src/main/python/bootstrap.py 692ce27
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78389
-----------------------------------------------------------
ambari-server/src/main/assemblies/server-windows.xml
<https://reviews.apache.org/r/32619/#comment127003>
For some obscure reason, the target bootstrap subdir is being clobered during setup-security, so the real destination needs to be sbin for the scripts, and resources for the zip archive.
ambari-server/src/main/python/bootstrap.py
<https://reviews.apache.org/r/32619/#comment127002>
Needs to be -File instead of -Command here
- Florian Barca
On March 30, 2015, 12:46 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 12:46 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
> ambari-server/src/main/python/bootstrap.py 111ff46
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78348
-----------------------------------------------------------
ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1
<https://reviews.apache.org/r/32619/#comment126908>
Minor: Remove extra spacings
ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1
<https://reviews.apache.org/r/32619/#comment126909>
Minor: Remove extra spacings
ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1
<https://reviews.apache.org/r/32619/#comment126910>
Minor: Remove extra spacings
ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1
<https://reviews.apache.org/r/32619/#comment126913>
Minor: Remove trailing extra spacings
ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1
<https://reviews.apache.org/r/32619/#comment126911>
Minor: Remove trailing extra spacings
ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1
<https://reviews.apache.org/r/32619/#comment126912>
Minor: Remove trailing extra spacings
- Jayush Luniya
On March 30, 2015, 12:46 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 12:46 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
> ambari-server/src/main/python/bootstrap.py 111ff46
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78346
-----------------------------------------------------------
ambari-server/src/main/python/bootstrap.py
<https://reviews.apache.org/r/32619/#comment126907>
+1
- Jayush Luniya
On March 30, 2015, 12:46 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 12:46 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
> ambari-server/src/main/python/bootstrap.py 111ff46
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78345
-----------------------------------------------------------
ambari-server/src/main/python/bootstrap.py
<https://reviews.apache.org/r/32619/#comment126904>
Please fork at the class level instead of forking every function that differs. It will avoid some of the if-else blocks and also make the code more readable.
class Bootstrap(threading.Thread)
@OsFamilyImpl(os_family=OsFamilyImpl.DEFAULT)
class BootstrapDefault(threading.Thread)
@OsFamilyImpl(os_family=OSConst.WINSRV_FAMILY)
class BootstrapWindows(threading.Thread)
ambari-server/src/main/python/bootstrap.py
<https://reviews.apache.org/r/32619/#comment126905>
You wont need this if-else if you fork at class level
ambari-server/src/main/python/bootstrap.py
<https://reviews.apache.org/r/32619/#comment126906>
Use constant string instead of hardcoding for Create-RemotingDir.ps1, Run-RemotingScript.ps1, Send-RemotingFile.ps1, Unzip-RemotingFile.ps1
- Jayush Luniya
On March 30, 2015, 12:46 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 12:46 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
> ambari-server/src/main/python/bootstrap.py 111ff46
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review78738
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On April 2, 2015, 8:47 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated April 2, 2015, 8:47 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/conf/windows/ambari.properties d0fb6dd
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 331b309
> ambari-server/src/main/python/bootstrap.py 692ce27
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> tested manyally
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/#review79313
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On April 7, 2015, 11:37 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32619/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 11:37 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10271
> https://issues.apache.org/jira/browse/AMBARI-10271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
>
>
> Diffs
> -----
>
> ambari-server/conf/windows/ambari.properties d0fb6dd
> ambari-server/src/main/assemblies/server-windows.xml 8b5483a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 331b309
> ambari-server/src/main/python/bootstrap.py 692ce27
> ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
> ambari-server/src/test/python/TestBootstrap.py 0dadaed
>
> Diff: https://reviews.apache.org/r/32619/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.466s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.433s]
> [INFO] Ambari Server ..................................... SUCCESS [1:13.917s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
> Also tested manually from command line and using API call.
> Bootstrap process completed success!
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/
-----------------------------------------------------------
(Updated Апрель 7, 2015, 11:37 п.п.)
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Changes
-------
test was fixed
Bugs: AMBARI-10271
https://issues.apache.org/jira/browse/AMBARI-10271
Repository: ambari
Description
-------
[WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
Diffs (updated)
-----
ambari-server/conf/windows/ambari.properties d0fb6dd
ambari-server/src/main/assemblies/server-windows.xml 8b5483a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 331b309
ambari-server/src/main/python/bootstrap.py 692ce27
ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
ambari-server/src/test/python/TestBootstrap.py 0dadaed
Diff: https://reviews.apache.org/r/32619/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [4.466s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.433s]
[INFO] Ambari Server ..................................... SUCCESS [1:13.917s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Also tested manually from command line and using API call.
Bootstrap process completed success!
Thanks,
Artem Baranchuk
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/
-----------------------------------------------------------
(Updated Апрель 2, 2015, 8:47 п.п.)
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Changes
-------
Included Florian's changes "Copying the parent environment vars in BSRunner.java"
Bugs: AMBARI-10271
https://issues.apache.org/jira/browse/AMBARI-10271
Repository: ambari
Description
-------
[WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
Diffs (updated)
-----
ambari-server/conf/windows/ambari.properties d0fb6dd
ambari-server/src/main/assemblies/server-windows.xml 8b5483a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 331b309
ambari-server/src/main/python/bootstrap.py 692ce27
ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
Diff: https://reviews.apache.org/r/32619/diff/
Testing
-------
tested manyally
Thanks,
Artem Baranchuk
Re: Review Request 32619: [WinTP2] Agent Automatic Bootstrap: Adapt
the bootstrap.py to upload bootstrap archive to agent node,
unzip and run setupAgent script on windows
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32619/
-----------------------------------------------------------
(Updated Апрель 1, 2015, 3:06 п.п.)
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Bugs: AMBARI-10271
https://issues.apache.org/jira/browse/AMBARI-10271
Repository: ambari
Description
-------
[WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload bootstrap archive to agent node, unzip and run setupAgent script on windows
Diffs (updated)
-----
ambari-server/conf/windows/ambari.properties cfe9c3d
ambari-server/src/main/assemblies/server-windows.xml 8b5483a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 8c27934
ambari-server/src/main/python/bootstrap.py 692ce27
ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 PRE-CREATION
ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 PRE-CREATION
Diff: https://reviews.apache.org/r/32619/diff/
Testing
-------
tested manyally
Thanks,
Artem Baranchuk