You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by Stefan Bodewig <bo...@apache.org> on 2011/09/06 14:28:03 UTC

First JIRA triage run complete

Hi all,

as you have seen in the storm of JIRA emails I went through all JIRA
issues and assigned them to some "fix version".  Some of them looked
invalid but I only closed the most obvious ones.

After I now have read all of them, on piece of code is sticking out as a
major pain point: RollingFileAppender.  A double digit number of issues
are raised against it.  I have assigned two or three of them to 1.2.11
but we can also push the whole thing back if it seems as if the code
needs some re-thought to get it right.

If anybody is looking for an isolated piece of code that needs to be
fixed without any need to understand the whole code base,
RollingFileAppender it is.  If anybody wants to play with it, please
raise your hand so we don't duplicate effort.

The next things I intend to focus on is fixing the currently failing
unit tests on Windows 7, generating the site (and fixing some related
doc issues while I'm at it) and the whole build system so we can
actually create a distribution.

Stefan

Re: First JIRA triage run complete

Posted by Stefan Bodewig <bo...@apache.org>.
On 2011-09-06, Roy Chastain wrote:

> I will take on RFA.  I have had my issues with it and even added a
> different rolling method for my local use.

Great.

I'll likely modify the test case to add tests for the MutexLock (I
suspect it doesn't work as advertized).  The resulting fixes won't touch
RFA but rather FileAppender, though.

> This brings us back to how do I get the current code with any additions
> to start working from.

First pull the current trunk from subversion - there now is a VS2010
solution that targets 4.0 you can start from.  I have also used NUnit's
GUI test runner on the test DLL created by VS and it works OK (I have
some test failures, but some of them happen with NAnt as well).

I don't think there are any patches appended to any of the open JIRA
issues WRT RollingFileAppender so svn is all you have.  In one of the
tickets Ron even mentions major changes in RFA since 1.2.10 so if there
were any patches they likely wouldn't apply anymore anyway.

It is also possible that some of the issues reported against 1.2.10 have
already been fixed by some of the changes Ron mentions.  It is probably
best to start with a test case (we always do that anyway, no ;-).

Once you are done, run "svn diff" in the top level directory and attach
the result as patch to the JIRA ticket.  I'll take care of it from
there.

Stefan

RE: First JIRA triage run complete

Posted by Roy Chastain <Ro...@roychastain.org>.
I will take on RFA.  I have had my issues with it and even added a
different rolling method for my local use.

This brings us back to how do I get the current code with any additions
to start working from.

----------------------------------------------------------------------
Roy Chastain




-----Original Message-----
From: Stefan Bodewig [mailto:bodewig@apache.org] 
Sent: Tuesday, September 06, 2011 08:28
To: log4net-dev@logging.apache.org
Subject: First JIRA triage run complete

Hi all,

as you have seen in the storm of JIRA emails I went through all JIRA
issues and assigned them to some "fix version".  Some of them looked
invalid but I only closed the most obvious ones.

After I now have read all of them, on piece of code is sticking out as a
major pain point: RollingFileAppender.  A double digit number of issues
are raised against it.  I have assigned two or three of them to 1.2.11
but we can also push the whole thing back if it seems as if the code
needs some re-thought to get it right.

If anybody is looking for an isolated piece of code that needs to be
fixed without any need to understand the whole code base,
RollingFileAppender it is.  If anybody wants to play with it, please
raise your hand so we don't duplicate effort.

The next things I intend to focus on is fixing the currently failing
unit tests on Windows 7, generating the site (and fixing some related
doc issues while I'm at it) and the whole build system so we can
actually create a distribution.

Stefan