You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/11/06 06:15:42 UTC
Review Request 71726: ATLAS-3510: Enable quick-search and suggestions
on entity labels
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71726/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, mayank jain, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sidharth Mishra.
Bugs: ATLAS-3510
https://issues.apache.org/jira/browse/ATLAS-3510
Repository: atlas
Description
-------
Searching on label name in quicksearch box doesn't return entities matching label names. This should follow the same behavior of classification name search in quick search
Solution:
label and user-defined properties are specially added manually when registering search-weights using solr-client
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 73108617c
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 7853dc15c
Diff: https://reviews.apache.org/r/71726/diff/1/
Testing
-------
Mamnually validated quick search and suggestions yields right result.
Thanks,
Sarath Subramanian
Re: Review Request 71726: ATLAS-3510: Enable quick-search and
suggestions on entity labels
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71726/#review218521
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java
Lines 54 (patched)
<https://reviews.apache.org/r/71726/#comment306263>
Not sure if search-weight for custom-attributes should be same as classifications & labels; perhaps these shouldn't be appear in suggestions as well. Consider assigning default search-weight (3) for custom-attributes.
- Madhan Neethiraj
On Nov. 6, 2019, 6:15 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71726/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 6:15 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, mayank jain, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3510
> https://issues.apache.org/jira/browse/ATLAS-3510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Searching on label name in quicksearch box doesn't return entities matching label names. This should follow the same behavior of classification name search in quick search
>
>
> Solution:
>
> label and user-defined properties are specially added manually when registering search-weights using solr-client
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 73108617c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 7853dc15c
>
>
> Diff: https://reviews.apache.org/r/71726/diff/1/
>
>
> Testing
> -------
>
> Mamnually validated quick search and suggestions yields right result.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71726: ATLAS-3510: Enable quick-search and
suggestions on entity labels
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71726/#review218522
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Nov. 6, 2019, 7:04 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71726/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 7:04 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, mayank jain, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3510
> https://issues.apache.org/jira/browse/ATLAS-3510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Searching on label name in quicksearch box doesn't return entities matching label names. This should follow the same behavior of classification name search in quick search
>
>
> Solution:
>
> label and user-defined properties are specially added manually when registering search-weights using solr-client
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 73108617c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 7853dc15c
>
>
> Diff: https://reviews.apache.org/r/71726/diff/2/
>
>
> Testing
> -------
>
> Mamnually validated quick search and suggestions yields right result.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71726: ATLAS-3510: Enable quick-search and
suggestions on entity labels
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71726/#review218548
-----------------------------------------------------------
It would help if there is a unit test for this.
- Ashutosh Mestry
On Nov. 6, 2019, 7:04 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71726/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 7:04 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, mayank jain, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3510
> https://issues.apache.org/jira/browse/ATLAS-3510
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Searching on label name in quicksearch box doesn't return entities matching label names. This should follow the same behavior of classification name search in quick search
>
>
> Solution:
>
> label and user-defined properties are specially added manually when registering search-weights using solr-client
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 73108617c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 7853dc15c
>
>
> Diff: https://reviews.apache.org/r/71726/diff/2/
>
>
> Testing
> -------
>
> Mamnually validated quick search and suggestions yields right result.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71726: ATLAS-3510: Enable quick-search and
suggestions on entity labels
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71726/
-----------------------------------------------------------
(Updated Nov. 5, 2019, 11:04 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, mayank jain, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sidharth Mishra.
Changes
-------
updated search-weight of custom-attributes to 3
Bugs: ATLAS-3510
https://issues.apache.org/jira/browse/ATLAS-3510
Repository: atlas
Description
-------
Searching on label name in quicksearch box doesn't return entities matching label names. This should follow the same behavior of classification name search in quick search
Solution:
label and user-defined properties are specially added manually when registering search-weights using solr-client
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 73108617c
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 7853dc15c
Diff: https://reviews.apache.org/r/71726/diff/2/
Changes: https://reviews.apache.org/r/71726/diff/1-2/
Testing
-------
Mamnually validated quick search and suggestions yields right result.
Thanks,
Sarath Subramanian